apps/web/app/(ee)/api/groups/route.ts (1)

30-54: Remove N+1 queries; rely on getGroups to return rewards/discounts.

Per‑group findUnique() inside Promise.all will not scale. Fetch rewards/discounts in getGroups() (JOINs/relations) and return groups directly here.

Apply this diff:

-    // Fetch rewards and discount data for each group
-    const groupsWithRewards = await Promise.all(
-      groups.map(async (group) => {
-        const groupWithRewards = await prisma.partnerGroup.findUnique({
-          where: { id: group.id },
-          include: {
-            clickReward: true,
-            leadReward: true,
-            saleReward: true,
-            discount: true,
-          },
-        });
-
-        return {
-          ...group,
-          clickReward: groupWithRewards?.clickReward,
-          leadReward: groupWithRewards?.leadReward,
-          saleReward: groupWithRewards?.saleReward,
-          discount: groupWithRewards?.discount,
-        };
-      })
-    );
-
-    return NextResponse.json(z.array(GroupSchemaExtended).parse(groupsWithRewards));
+    return NextResponse.json(z.array(GroupSchemaExtended).parse(groups));

apps/web/ui/partners/partner-row-item.tsx (4)

26-33: Use shared currency formatter for consistency and i18n.

Avoid manual $ + toFixed. Use currencyFormatter like elsewhere.

-import { cn } from "@dub/utils";
+import { cn, currencyFormatter } from "@dub/utils";
...
-    return `$${(reward.amount / 100).toFixed(2)}`;
+    return currencyFormatter(reward.amount / 100);
...
-                          New users get {discount.type === "percentage" ? `${discount.amount}%` : `$${(discount.amount / 100).toFixed(0)}`} off {getDurationText(discount.maxDuration)}
+                          New users get {discount.type === "percentage" ? `${discount.amount}%` : currencyFormatter(discount.amount / 100)} off {getDurationText(discount.maxDuration)}

Also applies to: 109-111

---

61-65: Don’t mutate props; sorting is redundant.

getGroupRewardsAndDiscount() already returns sorted rewards. Also avoid mutating rewards in place.

-  const sortedRewards = rewards.sort((a, b) => {
-    const order = { sale: 0, lead: 1, click: 2 } as const;
-    return (order[a.event as keyof typeof order] ?? 999) - (order[b.event as keyof typeof order] ?? 999);
-  });
+  const sortedRewards = rewards; // already ordered upstream

---

46-55: Include duration for lead/click rewards for consistency.

Align copy with sale rewards by appending duration.

       case "sale":
         return `Up to ${amount} per sale ${duration}`;
       case "lead":
-        return `${amount} per lead`;
+        return `${amount} per lead ${duration}`;
       case "click":
-        return `${amount} per click`;
+        return `${amount} per click ${duration}`;

---

68-79: Tighten types for event.

Use the union from RewardProps["event"] instead of string.

-  const getRewardIcon = (event: string) => {
+  const getRewardIcon = (event: RewardProps["event"]) => {

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx (1)

3-3: Remove unused groups fetch to avoid extra network call.

useGroups() is imported and invoked but not used; it triggers an unnecessary /api/groups request.

-import useGroups from "@/lib/swr/use-groups";
...
-    const { groups } = useGroups();

Also applies to: 56-56

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx (1)

169-179: Avoid O(n) group lookups per row; index groups by id.

Build a groupsById map once and reuse in both columns to cut repeated scans.

   const { groups } = useGroups();
+  const groupsById = useMemo(
+    () => Object.fromEntries((groups ?? []).map((g) => [g.id, g])),
+    [groups],
+  );
...
-            const group = groups?.find((g) => g.id === row.original.groupId);
+            const group = groupsById[row.original.groupId as string];
...
-            const group = groups.find((g) => g.id === row.original.groupId);
+            const group = groupsById[row.original.groupId as string];

Also applies to: 189-191

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/analytics-partners-table.tsx (1)

3-3: Remove unused useGroups to prevent redundant fetch.

groups isn’t used and causes an unnecessary /api/groups request.

-import useGroups from "@/lib/swr/use-groups";
...
-  const { groups } = useGroups();

Also applies to: 21-21

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: devkiran
PR: dubinc/dub#2735
File: apps/web/lib/actions/partners/delete-reward.ts:33-41
Timestamp: 2025-08-14T05:17:51.825Z
Learning: In the partner groups system, a rewardId can only belong to one group, establishing a one-to-one relationship between rewards and groups. This means using Prisma's `update` method (rather than `updateMany`) is appropriate when updating groups by rewardId.

Learnt from: devkiran
PR: dubinc/dub#2735
File: apps/web/lib/actions/partners/delete-reward.ts:33-41
Timestamp: 2025-08-14T05:17:51.825Z
Learning: In the partner groups system, a rewardId can only belong to one group, establishing a one-to-one relationship between rewards and groups. This means using Prisma's `update` method (rather than `updateMany`) is appropriate when updating groups by rewardId.

Learnt from: TWilson023
PR: dubinc/dub#2519
File: apps/web/ui/analytics/utils.ts:35-37
Timestamp: 2025-06-16T19:21:23.506Z
Learning: In the `useAnalyticsFilterOption` function in `apps/web/ui/analytics/utils.ts`, the pattern `options?.context ?? useContext(AnalyticsContext)` is intentionally designed as a complete replacement strategy, not a merge. When `options.context` is provided, it should contain all required fields (`baseApiPath`, `queryString`, `selectedTab`, `requiresUpgrade`) and completely replace the React context, not be merged with it. This is used for dependency injection or testing scenarios.

apps/web/ui/partners/partner-row-item.tsx (6)

110-110: Preserve cents for flat discounts.

Using toFixed(0) drops cents (e.g., $2.50 becomes $2). Align with reward formatting.

-                          New users get {discount.type === "percentage" ? `${discount.amount}%` : `$${(discount.amount / 100).toFixed(0)}`} off {getDurationText(discount.maxDuration)}
+                          New users get {discount.type === "percentage" ? `${discount.amount}%` : `$${(discount.amount / 100).toFixed(2)}`} off {getDurationText(discount.maxDuration)}

---

61-65: Avoid mutating rewards; sort a copy.

Prevent side effects by not sorting the original array.

-  const sortedRewards = rewards.sort((a, b) => {
+  const sortedRewards = [...rewards].sort((a, b) => {
     const order = { sale: 0, lead: 1, click: 2 } as const;
     return (order[a.event as keyof typeof order] ?? 999) - (order[b.event as keyof typeof order] ?? 999);
   });

---

68-79: Tighten typing for getRewardIcon.

Use the event union from RewardProps to catch typos at compile time.

-  const getRewardIcon = (event: string) => {
+  const getRewardIcon = (event: RewardProps["event"]) => {
     switch (event) {
       case "sale":
         return InvoiceDollar;
       case "lead":
         return UserPlus;
       case "click":
         return CursorRays;
       default:
         return CursorRays;
     }
   };

---

47-49: Only prepend “Up to” for percentage sale rewards.

Flat sale payouts aren’t “up to”.

-        return `Up to ${amount} per sale ${duration}`;
+        return `${reward.type === "percentage" ? "Up to " : ""}${amount} per sale ${duration}`;

---

121-125: Lazy‑load the avatar.

Small perf win, especially in tables.

-          <img
+          <img
+            loading="lazy"
             src={partner.image || `${OG_AVATAR_URL}${partner.name}`}
             alt={partner.name}
             className="size-5 shrink-0 rounded-full"
           />

---

4-4: Avoid deep import if possible.

If OG_AVATAR_URL is re‑exported from @dub/utils, prefer that path for stability.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: devkiran
PR: dubinc/dub#2735
File: apps/web/lib/actions/partners/delete-reward.ts:33-41
Timestamp: 2025-08-14T05:17:51.825Z
Learning: In the partner groups system, a rewardId can only belong to one group, establishing a one-to-one relationship between rewards and groups. This means using Prisma's `update` method (rather than `updateMany`) is appropriate when updating groups by rewardId.

apps/web/ui/partners/partner-row-item.tsx (1)

24-25: Prefer explicit conditional over ElementType union for Link.

Avoids prop mismatch/typing pitfalls and matches prior guidance.

-  const As = showPermalink ? Link : "div";
+  // render Link only when permalink is enabled

-      <As
-        {...(showPermalink && {
-          href: `/${slug}/program/partners?partnerId=${partner.id}`,
-          target: "_blank",
-          rel: "noopener noreferrer",
-        })}
-        className={cn(
-          "min-w-0 truncate",
-          showPermalink && "cursor-alias decoration-dotted hover:underline",
-        )}
-        title={partner.name}
-      >
-        {partner.name}
-      </As>
+      {showPermalink ? (
+        <Link
+          href={`/${slug}/program/partners?partnerId=${partner.id}`}
+          target="_blank"
+          rel="noopener noreferrer"
+          className={cn("min-w-0 truncate", "cursor-alias decoration-dotted hover:underline")}
+          title={partner.name}
+        >
+          {partner.name}
+        </Link>
+      ) : (
+        <div className="min-w-0 truncate" title={partner.name}>
+          {partner.name}
+        </div>
+      )}

Also applies to: 128-141

apps/web/ui/partners/partner-row-item.tsx (6)

7-8: Remove unused type and make imports type‑only.

DiscountProps isn’t used. Also mark these as type imports to avoid any runtime weight.

-import { GroupProps, RewardProps, DiscountProps } from "@/lib/types";
+import type { GroupProps, RewardProps } from "@/lib/types";

---

23-23: Type the route param for safety.

Slug can be inferred as string | string[] without a generic; constrain it.

-  const { slug } = useParams();
+  const { slug } = useParams<{ slug: string }>();

---

61-66: Avoid double‑sorting; util already returns sorted rewards.

getGroupRewardsAndDiscount() sorts; drop the extra sort and map directly.

-  // Sort rewards in the specified order: sale, lead, click
-  const sortedRewards = rewards.sort((a, b) => {
-    const order = { sale: 0, lead: 1, click: 2 } as const;
-    return (order[a.event as keyof typeof order] ?? 999) - (order[b.event as keyof typeof order] ?? 999);
-  });
+  // Rewards already sorted by getGroupRewardsAndDiscount

-                    {sortedRewards.map((reward) => {
+                    {rewards.map((reward) => {

Also applies to: 90-103

---

121-123: URL‑encode fallback avatar name.

Prevents broken URLs for names with spaces/special chars.

-            src={partner.image || `${OG_AVATAR_URL}${partner.name}`}
+            src={partner.image || `${OG_AVATAR_URL}${encodeURIComponent(partner.name)}`}

---

109-111: Keep currency precision for discounts.

Use two decimals like rewards for consistency.

-                          New users get {discount.type === "percentage" ? `${discount.amount}%` : `$${(discount.amount / 100).toFixed(0)}`} off {getDurationText(discount.maxDuration)}
+                          New users get {discount.type === "percentage" ? `${discount.amount}%` : `$${(discount.amount / 100).toFixed(2)}`} off {getDurationText(discount.maxDuration)}

---

68-69: Tighten icon helper signature.

Use the event union from RewardProps for better type safety.

-  const getRewardIcon = (event: string) => {
+  const getRewardIcon = (event: RewardProps["event"]) => {

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: devkiran
PR: dubinc/dub#2735
File: apps/web/lib/actions/partners/delete-reward.ts:33-41
Timestamp: 2025-08-14T05:17:51.825Z
Learning: In the partner groups system, a rewardId can only belong to one group, establishing a one-to-one relationship between rewards and groups. This means using Prisma's `update` method (rather than `updateMany`) is appropriate when updating groups by rewardId.

Learnt from: TWilson023
PR: dubinc/dub#2538
File: apps/web/ui/partners/overview/blocks/traffic-sources-block.tsx:50-82
Timestamp: 2025-06-18T20:23:38.835Z
Learning: Internal links within the same application that use target="_blank" may not require rel="noopener noreferrer" according to the team's security standards, even though it's generally considered a best practice for any target="_blank" link.