apps/web/ui/partners/partner-application-sheet.tsx (1)

262-267: Pass groupId to approval action to avoid wrong group assignment

Approve is gated on partner.groupId, but executeAsync omits it. If the action defaults to program.defaultGroupId when groupId is absent, approvals will land in the wrong group. Add a guard and pass groupId explicitly.

-    onConfirm: async () => {
-      if (!program || !workspaceId) return;
-
-      await executeAsync({
-        workspaceId: workspaceId,
-        partnerId: partner.id,
-      });
-    },
+    onConfirm: async () => {
+      if (!program || !workspaceId) {
+        toast.error("Missing program or workspace. Please refresh and try again.");
+        return;
+      }
+      if (!partner.groupId) {
+        toast.error("Select a group before approving.");
+        return;
+      }
+      await executeAsync({
+        workspaceId,
+        partnerId: partner.id,
+        groupId: partner.groupId,
+      });
+    },

Run to confirm current server logic:

#!/bin/bash
rg -nP -C3 'approvePartnerAction|approve-partner-enrollment|groupId\s*:\s*groupId\s*\|\|\s*program\.defaultGroupId'

apps/web/ui/partners/partner-about.tsx (1)

19-25: Preserve author formatting in description

Allow line breaks and long words to wrap.

-        <p className="text-content-default text-xs">
+        <p className="text-content-default text-xs whitespace-pre-wrap break-words">

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx (1)

379-382: Loading state simplification is fine

Using only isLoading matches the removed current-partner side fetch.

Since the details sheet was removed, consider deleting the unused useCurrentPartner helper at the bottom to reduce dead code.

apps/web/ui/partners/partner-application-tabs.tsx (2)

49-86: Add ARIA roles for tabs for better accessibility.

Declare a tablist and mark buttons as tabs with aria-selected.

-    <div className="scrollbar-hide relative z-0 flex items-center justify-between gap-1 overflow-x-auto p-2">
+    <div
+      className="scrollbar-hide relative z-0 flex items-center justify-between gap-1 overflow-x-auto p-2"
+      role="tablist"
+      aria-label="Partner application"
+    >
@@
-              <button
+              <button
                 key={id}
                 type="button"
                 onClick={() => setCurrentTabId(id)}
-                data-selected={isSelected}
+                role="tab"
+                aria-selected={isSelected}
+                data-selected={isSelected}
                 className={cn(

---

70-72: Prefer design tokens over hard-coded color.

Replace bg-blue-600/text-white with your design system tokens (e.g., bg-accent text-accent-foreground) for theme consistency.

apps/web/ui/partners/partner-comments.tsx (3)

86-93: Also invalidate the comments count; avoid double revalidation.

Update mutations to refresh both list and count; avoid SWR’s extra revalidate since you’re explicitly invalidating.

           mutate(
             async (data) => {
@@
             },
             {
               optimisticData: (data) =>
                 data ? [optimisticComment, ...data] : [optimisticComment],
               rollbackOnError: true,
+              revalidate: false,
             },
           )
-            .then(() => mutatePrefix(`/api/partners/${partnerId}/comments`))
+            .then(() =>
+              mutatePrefix([
+                `/api/partners/${partnerId}/comments`,
+                `/api/partners/${partnerId}/comments/count`,
+              ]),
+            )

-      onSuccess: () => {
+      onSuccess: () => {
         toast.success("Comment edited successfully");
-        mutatePrefix(`/api/partners/${partnerId}/comments`);
+        mutatePrefix(`/api/partners/${partnerId}/comments`);
       },

-      onSuccess: () => {
+      onSuccess: () => {
         toast.success("Comment deleted successfully");
-        mutatePrefix(`/api/partners/${partnerId}/comments`);
+        mutatePrefix([
+          `/api/partners/${partnerId}/comments`,
+          `/api/partners/${partnerId}/comments/count`,
+        ]);
       },

Also applies to: 146-147, 156-157

---

239-247: Use the app’s confirm modal for consistency.

Replace window.confirm with your ConfirmModal for unified UX and keyboard handling.

---

193-206: Locale handling nit.

toLocaleTimeString("en-US") hardcodes locale. Consider using formatDate/timeAgo utilities for consistency with the rest of the UI.

apps/web/ui/partners/partner-application-sheet.tsx (5)

279-286: Prevent double-submits on Approve

Also disable the button while the action is pending.

-          disabled={!partner.groupId}
+          disabled={!partner.groupId || isPending}

---

53-64: Add rel to target=_blank link

Open-in-new-tab links should use rel="noopener noreferrer" to prevent window.opener leaks.

-          <Link
-            href={`/${workspaceSlug}/program/messages/${partner.id}`}
-            target="_blank"
-          >
+          <Link
+            href={`/${workspaceSlug}/program/messages/${partner.id}`}
+            target="_blank"
+            rel="noopener noreferrer"
+          >

---

57-63: Keep URL state consistent when opening Messages

Consider also clearing partnerId from the URL when closing via the Message button to avoid stale state.

-            <Button
+            <Button
               variant="secondary"
               text="Message"
               icon={<Msgs className="size-4 shrink-0" />}
-              onClick={() => setIsOpen(false)}
+              onClick={() => {
+                setIsOpen(false);
+                // keep URL in sync with closed sheet
+                queryParams({ del: "partnerId", scroll: false });
+              }}
               className="hidden h-9 rounded-lg px-4 sm:flex"
             />

Add the hook near the other hooks in this component:

-  const { slug: workspaceSlug } = useWorkspace();
+  const { slug: workspaceSlug } = useWorkspace();
+  const { queryParams } = useRouterStuff();

---

66-81: Add accessible labels to navigation buttons

Icon-only buttons need an accessible name.

             <Button
               type="button"
               disabled={!onPrevious}
               onClick={onPrevious}
               variant="secondary"
               className="size-9 rounded-l-lg rounded-r-none p-0"
               icon={<ChevronLeft className="size-3.5" />}
+              aria-label="Previous partner"
             />
             <Button
               type="button"
               disabled={!onNext}
               onClick={onNext}
               variant="secondary"
               className="-ml-px size-9 rounded-l-none rounded-r-lg p-0"
               icon={<ChevronRight className="size-3.5" />}
+              aria-label="Next partner"
             />

---

83-89: Add aria-label to Close button

Improve accessibility for the icon-only close control.

-            <Button
+            <Button
               variant="outline"
               icon={<X className="size-5" />}
               className="h-auto w-fit p-1"
+              aria-label="Close"
             />

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/ui/partners/partner-application-sheet.tsx (1)

267-270: Approval call omits groupId (verify backend expectation).

You disable Approve unless partner.groupId exists, but don’t pass it to the action. If the action defaults to program.defaultGroupId when groupId is absent, approved partners may land in the wrong group.

If the action expects/uses groupId, pass it:

   await executeAsync({
     workspaceId: workspaceId,
     partnerId: partner.id,
+    groupId: partner.groupId,
   });

Run to verify server semantics:

#!/bin/bash
# Inspect approve-partner action usage of groupId/defaultGroupId
fd -a 'approve-partner' | xargs -I{} rg -n -C3 -e '\bgroupId\b|\bdefaultGroupId\b' {}
# Also check for an "approve-partner-enrollment" path if present
rg -n -C3 -e 'approve[-_]?partner.*(groupId|defaultGroupId)' apps lib packages

apps/web/ui/partners/partner-application-sheet.tsx (4)

54-66: Add rel for target=_blank and guard undefined slug.

Security/a11y nit: include rel="noopener noreferrer". Also consider hiding the button until workspaceSlug is ready to avoid "/undefined/..." links.

-  <Link
-    href={`/${workspaceSlug}/program/messages/${partner.id}`}
-    target="_blank"
-  >
+  {workspaceSlug && (
+    <Link
+      href={`/${workspaceSlug}/program/messages/${partner.id}`}
+      target="_blank"
+      rel="noopener noreferrer"
+    >
       <Button ... />
-  </Link>
+    </Link>
+  )}

---

67-83: Icon‑only nav buttons need accessible labels.

Add aria-label so screen readers announce their purpose.

   <Button
     type="button"
     disabled={!onPrevious}
     onClick={onPrevious}
     variant="secondary"
     className="size-9 rounded-l-lg rounded-r-none p-0"
+    aria-label="Previous application"
     icon={<ChevronLeft className="size-3.5" />}
   />
   <Button
     type="button"
     disabled={!onNext}
     onClick={onNext}
     variant="secondary"
     className="-ml-px size-9 rounded-l-none rounded-r-lg p-0"
+    aria-label="Next application"
     icon={<ChevronRight className="size-3.5" />}
   />

---

158-166: Avoid “undefined” program name during initial render.

When program hasn’t loaded, the title renders “promote undefined?”. Gate the fields on program or provide a neutral fallback.

-  const fields = [
+  const fields = program ? [
     {
-      title: `How do you plan to promote ${program?.name}?`,
+      title: `How do you plan to promote ${program.name}?`,
       value: application?.proposal,
     },
     {
       title: "Any additional questions or comments?",
       value: application?.comments,
     },
-  ];
+  ] : [];

And render a lightweight placeholder when !program:

-  return (
-    <div className="grid grid-cols-1 gap-6 text-xs">
-      {fields.map((field) => (
+  return (
+    <div className="grid grid-cols-1 gap-6 text-xs">
+      {program ? fields.map((field) => (
         ...
-      ))}
+      )) : (
+        <div className="h-4 w-28 min-w-0 animate-pulse rounded-md bg-neutral-200" />
+      )}

Also applies to: 170-197

---

330-333: Non‑null assertion on workspaceId.

workspaceId! can throw if context isn’t ready. Mirror the approve path’s guard or disable the button until available.

-  await rejectPartner({
-    workspaceId: workspaceId!,
-    partnerId: partner.id,
-  });
+  if (!workspaceId) return;
+  await rejectPartner({ workspaceId, partnerId: partner.id });

apps/web/ui/modals/confirm-modal.tsx (1)

89-101: Minor: type name typo (Model → Modal).

Rename for clarity; no behavior change.

-type PromptModelProps = {
+type PromptModalProps = {
   ...
-};
+};
 ...
-function ConfirmModal({
+function ConfirmModal({
   ...
-}: { ... } & PromptModelProps) {
+}: { ... } & PromptModalProps) {
 ...
-export function useConfirmModal(props: PromptModelProps) {
+export function useConfirmModal(props: PromptModalProps) {

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/ui/partners/partner-application-sheet.tsx (6)

54-57: Add rel for security when using target="_blank".

Include rel="noopener noreferrer" to prevent tab‑nabbing.

-          <Link
+          <Link
             href={`/${workspaceSlug}/program/messages/${partner.id}`}
             target="_blank"
+            rel="noopener noreferrer"
           >

---

67-83: Provide accessible labels for icon‑only navigation buttons.

Screen readers won’t announce intent without an accessible name.

           <Button
             type="button"
             disabled={!onPrevious}
             onClick={onPrevious}
             variant="secondary"
             className="size-9 rounded-l-lg rounded-r-none p-0"
+            aria-label="Previous application"
             icon={<ChevronLeft className="size-3.5" />}
           />
           <Button
             type="button"
             disabled={!onNext}
             onClick={onNext}
             variant="secondary"
             className="-ml-px size-9 rounded-l-none rounded-r-lg p-0"
+            aria-label="Next application"
             icon={<ChevronRight className="size-3.5" />}
           />

---

170-193: Avoid wrapping fallback text in Linkify.

Simplifies markup and prevents link styles on “No response provided”.

-          <div className="mt-2">
-            {field.value || field.value === "" ? (
-              <Linkify
-                as="p"
-                options={{
-                  target: "_blank",
-                  rel: "noopener noreferrer nofollow",
-                  className:
-                    "underline underline-offset-4 text-neutral-400 hover:text-neutral-700",
-                }}
-              >
-                {field.value || (
-                  <span className="text-content-muted italic">
-                    No response provided
-                  </span>
-                )}
-              </Linkify>
-            ) : (
-              <div className="h-4 w-28 min-w-0 animate-pulse rounded-md bg-neutral-200" />
-            )}
-          </div>
+          <div className="mt-2">
+            {field.value === undefined ? (
+              <div className="h-4 w-28 min-w-0 animate-pulse rounded-md bg-neutral-200" />
+            ) : field.value ? (
+              <Linkify
+                as="p"
+                options={{
+                  target: "_blank",
+                  rel: "noopener noreferrer nofollow",
+                  className:
+                    "underline underline-offset-4 text-neutral-400 hover:text-neutral-700",
+                }}
+              >
+                {field.value}
+              </Linkify>
+            ) : (
+              <p className="text-content-muted italic">No response provided</p>
+            )}
+          </div>

---

283-291: Disable Approve until required data is loaded.

Prevents a no‑op confirm when program/workspaceId aren’t ready.

         <Button
           type="button"
           variant="primary"
           text="Approve"
           shortcut="A"
           loading={isPending}
           onClick={() => setShowConfirmModal(true)}
+          disabled={!program || !workspaceId}
           className="w-fit shrink-0"
         />

---

304-315: Also clear partnerId from URL on reject (parity with approve).

Prevents the sheet from reopening due to a lingering query param.

   const { id: workspaceId } = useWorkspace();
+  const { queryParams } = useRouterStuff();

       onSuccess: async () => {
         await mutatePrefix("/api/partners");
         toast.success(
           "Application rejected. No email sent, and they can reapply in 30 days.",
         );
+        queryParams({ del: "partnerId" });
         setIsOpen(false);
       },

---

33-35: Optional: Arrow‑key navigation between applications.

Small UX boost: allow ArrowLeft/Right to trigger previous/next when available.

   const [currentTabId, setCurrentTabId] = useState<string>("about");
+  useKeyboardShortcut("ArrowLeft", () => onPrevious?.(), { sheet: true });
+  useKeyboardShortcut("ArrowRight", () => onNext?.(), { sheet: true });

Also applies to: 44-46

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2858
File: apps/web/ui/partners/partner-application-sheet.tsx:262-266
Timestamp: 2025-09-18T17:03:06.183Z
Learning: The useKeyboardShortcut hook with context options like {sheet: true, modal: true} requires ALL specified contexts to be present simultaneously. The shortcut will only trigger when both existingSheetBackdrop and existingModalBackdrop are present, using strict equality matching in the implementation.