Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Partner sheet online presence card updates #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Jul 9, 2025
Merged

Partner sheet online presence card updates #2622

steven-tey merged 1 commit into from
Jul 9, 2025

Conversation

@TWilson023
Copy link
Collaborator

@TWilson023 TWilson023 commented Jul 8, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Introduced a new card component for displaying online presence entries with icons, verification status, additional information, and optional actions.

  • Refactor

    • Replaced inline rendering of online presence entries with the new card component for a more consistent and maintainable UI.
    • Adjusted spacing in the partner profile sheet for improved layout.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025 •
edited
Loading

Walkthrough

A new reusable React component, OnlinePresenceCard, was introduced to encapsulate the display logic for online presence entries, including icons, verification status, and optional actions. Existing components that previously rendered these entries inline were refactored to use the new card component, simplifying their markup and centralizing presentation logic.

Changes

File(s) Change Summary
apps/web/ui/partners/online-presence-card.tsx Added new OnlinePresenceCard and internal Container components to encapsulate online presence entry UI logic.
apps/web/ui/partners/online-presence-form.tsx Refactored to use OnlinePresenceCard for rendering presence entries; removed unused icon imports.
apps/web/ui/partners/online-presence-summary.tsx Replaced inline JSX for presence entries with OnlinePresenceCard; removed related icon and tooltip imports.
apps/web/ui/partners/partner-profile-sheet.tsx Adjusted vertical margin above OnlinePresenceSummary from mt-2 to mt-3.

Sequence Diagram(s)

sequenceDiagram
    participant ParentComponent as Parent (e.g., OnlinePresenceForm/Summary)
    participant OnlinePresenceCard
    participant Container

    ParentComponent->>OnlinePresenceCard: Render with props (icon, value, etc.)
    OnlinePresenceCard->>Container: Render with href/className/children
    Container-->>OnlinePresenceCard: Returns anchor or div
    OnlinePresenceCard-->>ParentComponent: Renders card UI (icon, value, badge, info, actions)
Loading

Poem

🐇
A card now hops where code once sprawled,
With icons bright and badges called.
The presence lines are neat and trim,
Refactored code—no longer grim!
One card to rule the online show,
And rabbits cheer as changes flow.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8779637 and fce6942.

📒 Files selected for processing (4)
  • apps/web/ui/partners/online-presence-card.tsx (1 hunks)
  • apps/web/ui/partners/online-presence-form.tsx (3 hunks)
  • apps/web/ui/partners/online-presence-summary.tsx (2 hunks)
  • apps/web/ui/partners/partner-profile-sheet.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
apps/web/ui/partners/online-presence-summary.tsx (1) 
Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.
🧬 Code Graph Analysis (3)
apps/web/ui/partners/partner-profile-sheet.tsx (1)
apps/web/ui/partners/online-presence-summary.tsx (1)
  • OnlinePresenceSummary (89-133)
apps/web/ui/partners/online-presence-summary.tsx (2)
apps/web/ui/partners/online-presence-card.tsx (1)
  • OnlinePresenceCard (12-78)
packages/ui/src/icons/index.tsx (1)
  • Icon (77-77)
apps/web/ui/partners/online-presence-form.tsx (2)
apps/web/ui/partners/online-presence-card.tsx (1)
  • OnlinePresenceCard (12-78)
packages/ui/src/icons/index.tsx (1)
  • Icon (77-77)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: label_on_pr
🔇 Additional comments (6)
apps/web/ui/partners/partner-profile-sheet.tsx (1)

101-101: LGTM! Appropriate margin adjustment for the new card component.

The increase from mt-2 to mt-3 provides better visual spacing that aligns with the updated OnlinePresenceCard component presentation.

apps/web/ui/partners/online-presence-summary.tsx (1)

116-122: Excellent refactoring to use the new reusable card component.

The migration from inline JSX to OnlinePresenceCard centralizes the presentation logic while maintaining the same functionality. The prop mapping is clean and handles null values appropriately.

apps/web/ui/partners/online-presence-form.tsx (2)

553-553: Good TypeScript type assertion.

The explicit cast to string[] is necessary since filter(Boolean) removes falsy values but TypeScript still infers the array could contain null values.

571-578: Clean refactoring with proper callback handling.

The migration to OnlinePresenceCard is well-implemented with the onRemove callback properly clearing the form field via setValue.

apps/web/ui/partners/online-presence-card.tsx (2)

12-78: Well-designed reusable component with excellent prop handling.

The OnlinePresenceCard component effectively centralizes the online presence UI logic with:

  • Clean conditional rendering for links vs. static content
  • Proper accessibility attributes for external links
  • Appropriate hover effects and transitions
  • Good handling of optional props (prefix, verified, info)
  • Consistent styling with the design system

80-92: Smart pattern for conditional container rendering.

The Container component provides a clean abstraction for rendering either an anchor or div based on the href prop, with proper external link attributes when needed.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link
Contributor

vercel bot commented Jul 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dub ✅ Ready (Inspect) Visit Preview Jul 8, 2025 3:26pm

@TWilson023 TWilson023 requested a review from steven-tey July 8, 2025 15:17
@steven-tey steven-tey merged commit 77ba5b1 into main Jul 9, 2025
9 checks passed
@steven-tey steven-tey deleted the online-presence-cards-2 branch July 9, 2025 02:38
This was referenced Sep 16, 2025
Merged
Closed
Merged
Merged
This was referenced Sep 24, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TWilson023 @steven-tey