apps/web/ui/layout/sidebar/partners-sidebar-nav.tsx (1)

268-275: Confirm intent: Messages/profile/payouts routes no longer render area nav

Returning null for currentArea on routes starting with /messages, /profile, or /payouts hides the area-specific sidebar (e.g., program nav). This means navigating to a program’s Messages page (/messages/[programSlug]) drops the program area nav and also switches the bottom slot to <PayoutStats /> (since isEnrolledProgramPage is false on /messages/*). If that UX is intended, all good; otherwise we should refine the check to keep currentArea="program" for program-specific message threads.

• Extract the top-level group paths to a constant to centralize and reduce churn.
• Nit: programSlug in the useMemo deps is redundant given isEnrolledProgramPage already depends on it.

Apply this diff to use a constant in the check:

-        : ["/payouts", "/profile", "/messages"].some((p) =>
-              pathname.startsWith(p),
-            )
+        : TOP_LEVEL_GROUP_PATHS.some((p) => pathname.startsWith(p))
           ? null
           : isEnrolledProgramPage
             ? "program"
             : "programs";

Add this constant near the top of the file (e.g., after the type SidebarNavData):

const TOP_LEVEL_GROUP_PATHS = ["/payouts", "/profile", "/messages"] as const;

Optionally tighten the deps:

// Current:
// }, [pathname, programSlug, isEnrolledProgramPage]);

// Suggested:
// }, [pathname, isEnrolledProgramPage]);

apps/web/ui/partners/online-presence-form.tsx (2)

233-233: LGTM on variant pass-through

Passing variant to each FormRow keeps the layout consistent across modes.

Minor: to reduce repetition, consider giving FormRow a default variant or deriving it via context so call sites don’t need to pass it every time (see next comment for a safe default-prop tweak).

Also applies to: 268-268, 299-299, 331-331, 363-363, 397-397

---

539-551: Make variant optional with a default to cut call-site churn

Defaulting variant to "onboarding" is safe and reduces required props. Current usages remain valid.

Apply this diff:

 function FormRow({
   label,
   input,
   property,
   prefix,
   verifiedAtField,
   icon: Icon,
   onVerifyClick,
   verifyDisabledTooltip,
-  variant,
+  variant = "onboarding",
 }: {
   label: string;
   input: ReactNode;
 
   property: keyof OnlinePresenceFormData;
   prefix?: string;
   verifiedAtField: string;
   icon: Icon;
   onVerifyClick: () => Promise<boolean>;
   verifyDisabledTooltip?: string;
-  variant: "onboarding" | "settings";
+  variant?: "onboarding" | "settings";
 }) {

apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/industry-interests-modal.tsx (2)

41-43: Sync local selection when the modal opens or props change.

Initialize-once state can drift from props. Reset when opening or when interests change.

-import { Dispatch, SetStateAction, useRef, useState } from "react";
+import { Dispatch, SetStateAction, useEffect, useRef, useState } from "react";
@@
   const [selectedInterests, setSelectedInterests] =
     useState<IndustryInterest[]>(interests);
+
+  useEffect(() => {
+    if (show) setSelectedInterests(interests);
+  }, [show, interests]);

---

51-55: Copy nits.

Polish the heading and description.

-          Add industry Interests
+          Add industry interests
@@
-          Add the industries you care and post content about.
+          Add the industries you care about and post content about.

apps/web/lib/api/partners/get-partner-for-program.ts (1)

72-90: Prefer JSON arrays over comma-joined strings for enum lists.

Use JSON_ARRAYAGG (and DISTINCT) in subqueries to avoid string parsing and ensure type-safety. Then drop .split(",") in the mapper.

-    LEFT JOIN (
-      SELECT partnerId, group_concat(industryInterest) AS industryInterests
+    LEFT JOIN (
+      SELECT partnerId, JSON_ARRAYAGG(DISTINCT industryInterest) AS industryInterests
       FROM PartnerIndustryInterest
       WHERE partnerId = ${partnerId}
       GROUP BY partnerId
     ) industryInterests ON industryInterests.partnerId = pe.partnerId
-    LEFT JOIN (
-      SELECT partnerId, group_concat(preferredEarningStructure) AS preferredEarningStructures
+    LEFT JOIN (
+      SELECT partnerId, JSON_ARRAYAGG(DISTINCT preferredEarningStructure) AS preferredEarningStructures
       FROM PartnerPreferredEarningStructure
       WHERE partnerId = ${partnerId}
       GROUP BY partnerId
     ) preferredEarningStructures ON preferredEarningStructures.partnerId = pe.partnerId
-    LEFT JOIN (
-      SELECT partnerId, group_concat(salesChannel) AS salesChannels
+    LEFT JOIN (
+      SELECT partnerId, JSON_ARRAYAGG(DISTINCT salesChannel) AS salesChannels
       FROM PartnerSalesChannel
       WHERE partnerId = ${partnerId}
       GROUP BY partnerId
     ) salesChannels ON salesChannels.partnerId = pe.partnerId

-    industryInterests: partner[0].industryInterests?.split(",") || undefined,
-    preferredEarningStructures:
-      partner[0].preferredEarningStructures?.split(",") || undefined,
-    salesChannels: partner[0].salesChannels?.split(",") || undefined,
+    industryInterests: partner[0].industryInterests || undefined,
+    preferredEarningStructures: partner[0].preferredEarningStructures || undefined,
+    salesChannels: partner[0].salesChannels || undefined,

apps/web/ui/shared/max-characters-counter.tsx (1)

15-21: Small robustness tweak and optional UX improvement.

Guard non-string values and optionally flag over-limit state.

-  const value = useWatch({ control, name });
+  const value = useWatch({ control, name });
+  const length =
+    typeof value === "string" ? value.length : value?.toString().length ?? 0;
@@
-    <span className={cn("text-content-subtle text-xs", className)}>
-      {value?.toString().length || 0}/{maxLength}
+    <span
+      className={cn(
+        "text-xs",
+        length > maxLength ? "text-red-600" : "text-content-subtle",
+        className,
+      )}
+    >
+      {length}/{maxLength}
     </span>

apps/web/ui/partners/partner-about.tsx (1)

92-101: Prefer explicit nullish check for monthlyTraffic.

Guard on defined/undefined rather than truthiness; avoids surprises if enum ever includes falsy-like values.

-      {Boolean(partner.monthlyTraffic) && (
+      {partner.monthlyTraffic != null && (
         <div className="flex flex-col gap-2">
           <h3 className="text-content-emphasis text-xs font-semibold">
             Monthly traffic
           </h3>
           <span className="text-content-default text-xs">
-            {monthlyTrafficAmountsMap[partner.monthlyTraffic!]?.label ?? "-"}
+            {monthlyTrafficAmountsMap[partner.monthlyTraffic]?.label ?? "-"}
           </span>
         </div>
       )}

apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/profile-details-form.tsx (1)

197-202: Optimize image change detection

The current implementation sends image: null when the image hasn't changed, which could unnecessarily trigger update logic on the backend. Consider not including the image field at all when it hasn't changed.

Apply this optimization:

await executeAsync({
  ...data,
-  image: imageChanged ? data.image : null,
+  ...(imageChanged && { image: data.image }),
});

apps/web/lib/actions/partners/update-partner-profile.ts (2)

192-193: Inconsistent undefined check pattern

The undefined check for country uses a different pattern than profileType (line 196). Also, the code allows setting country to null but then compares with undefined.

For consistency and clarity:

const countryChanged =
-  input.country !== undefined &&
-  partner.country?.toLowerCase() !== input.country?.toLowerCase();
+  input.country != null &&
+  partner.country?.toLowerCase() !== input.country?.toLowerCase();

---

71-71: Consider stricter email validation

The condition newEmail !== undefined means an empty string would pass through. Consider also checking for non-empty strings.

-const emailChanged = newEmail !== undefined && partner.email !== newEmail;
+const emailChanged = newEmail && newEmail !== partner.email;

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.

Learnt from: TWilson023
PR: dubinc/dub#2857
File: apps/web/lib/actions/partners/update-program.ts:96-0
Timestamp: 2025-09-17T17:44:03.965Z
Learning: In apps/web/lib/actions/partners/update-program.ts, the team prefers to keep the messagingEnabledAt update logic simple by allowing client-provided timestamps rather than implementing server-controlled timestamp logic to avoid added complexity.

packages/ui/src/icons/nucleo/cloud.tsx (1)

12-28: Deduplicate SVG attributes; remove redundant fill and push shared stroke to the group

Both paths repeat identical stroke and fill props, while the parent group sets an unused fill. Centralize shared attributes on the and simplify the paths.

Apply this diff:

-      <g fill="currentColor">
-        <path
-          d="M13.464,6.891c-.186-2.314-2.102-4.141-4.464-4.141-2.485,0-4.5,2.015-4.5,4.5,0,.35,.049,.686,.124,1.013-1.597,.067-2.874,1.374-2.874,2.987,0,1.657,1.343,3,3,3h7.75c2.071,0,3.75-1.679,3.75-3.75,0-1.736-1.185-3.182-2.786-3.609Z"
-          fill="none"
-          stroke="currentColor"
-          strokeLinecap="round"
-          strokeLinejoin="round"
-          strokeWidth="1.5"
-        />
-        <path
-          d="M9.705,8c.687-.767,1.684-1.25,2.795-1.25,.333,0,.657,.059,.964,.141"
-          fill="none"
-          stroke="currentColor"
-          strokeLinecap="round"
-          strokeLinejoin="round"
-          strokeWidth="1.5"
-        />
+      <g fill="none" stroke="currentColor" strokeLinecap="round" strokeLinejoin="round" strokeWidth="1.5">
+        <path d="M13.464,6.891c-.186-2.314-2.102-4.141-4.464-4.141-2.485,0-4.5,2.015-4.5,4.5,0,.35,.049,.686,.124,1.013-1.597,.067-2.874,1.374-2.874,2.987,0,1.657,1.343,3,3,3h7.75c2.071,0,3.75-1.679,3.75-3.75,0-1.736-1.185-3.182-2.786-3.609Z" />
+        <path d="M9.705,8c.687-.767,1.684-1.25,2.795-1.25,.333,0,.657,.059,.964,.141" />
       </g>

apps/web/lib/actions/partners/update-partner-profile.ts (3)

97-122: Avoid shadowing outer name and improve readability in map callbacks

The callback param name shadows the outer name field. Rename to value (or similar) in each map to reduce confusion.

Apply this diff:

-          ...(industryInterests && {
+          ...(industryInterests && {
             industryInterests: {
               deleteMany: {},
-              create: industryInterests.map((name) => ({
-                industryInterest: name,
+              create: industryInterests.map((value) => ({
+                industryInterest: value,
               })),
             },
           }),
 
-          ...(preferredEarningStructures && {
+          ...(preferredEarningStructures && {
             preferredEarningStructures: {
               deleteMany: {},
-              create: preferredEarningStructures.map((name) => ({
-                preferredEarningStructure: name,
+              create: preferredEarningStructures.map((value) => ({
+                preferredEarningStructure: value,
               })),
             },
           }),
 
-          ...(salesChannels && {
+          ...(salesChannels && {
             salesChannels: {
               deleteMany: {},
-              create: salesChannels.map((name) => ({
-                salesChannel: name,
+              create: salesChannels.map((value) => ({
+                salesChannel: value,
               })),
             },
           }),

---

181-184: Harden error handling: error is unknown

Accessing error.message directly can throw if error isn’t an Error. Guard it to avoid masking the real failure.

Apply this diff:

-    } catch (error) {
-      console.error(error);
-
-      throw new Error(error.message);
-    }
+    } catch (error) {
+      console.error(error);
+      const message =
+        error instanceof Error ? error.message : "Failed to update partner profile";
+      throw new Error(message);
+    }

---

225-228: Align error messaging with actual constraints (include company name)

You also gate on companyName changes, but the message mentions only country/profile type. Include company name to reduce confusion.

-      "Since you've already received payouts on Dub, you cannot change your country or profile type. Please contact support to update those fields.",
+      "Since you've already received payouts on Dub, you cannot change your country, profile type, or company name. Please contact support to update those fields.",

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: TWilson023
PR: dubinc/dub#2857
File: apps/web/lib/actions/partners/update-program.ts:96-0
Timestamp: 2025-09-17T17:44:03.965Z
Learning: In apps/web/lib/actions/partners/update-program.ts, the team prefers to keep the messagingEnabledAt update logic simple by allowing client-provided timestamps rather than implementing server-controlled timestamp logic to avoid added complexity.

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx:56-66
Timestamp: 2025-07-30T15:25:13.936Z
Learning: In apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx, the form schema uses partial condition objects to allow users to add empty/unconfigured condition fields without type errors, while submission validation uses strict schemas to ensure data integrity. This two-stage validation pattern improves UX by allowing progressive completion of complex forms.

Learnt from: TWilson023
PR: dubinc/dub#2872
File: apps/web/lib/actions/partners/update-partner-profile.ts:97-104
Timestamp: 2025-09-24T15:57:55.259Z
Learning: In the Dub codebase, the team prefers to maintain consistency with existing patterns for database operations, even if there are theoretical improvements available. The deleteMany: {} pattern for relation updates is an accepted approach that the team considers low-risk.

Learnt from: TWilson023
PR: dubinc/dub#2872
File: apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/profile-details-form.tsx:218-219
Timestamp: 2025-09-24T15:51:28.818Z
Learning: In the Dub codebase, OG_AVATAR_URL concatenation with partner names follows a consistent pattern throughout the application where names are used directly without URL encoding. This is an established codebase-wide pattern.

Learnt from: TWilson023
PR: dubinc/dub#2673
File: apps/web/ui/partners/rewards/rewards-logic.tsx:268-275
Timestamp: 2025-07-30T15:29:54.131Z
Learning: In apps/web/ui/partners/rewards/rewards-logic.tsx, when setting the entity field in a reward condition, dependent fields (attribute, operator, value) should be reset rather than preserved because different entities (customer vs sale) have different available attributes. Maintaining existing fields when the entity changes would create invalid state combinations and confusing UX.

Learnt from: TWilson023
PR: dubinc/dub#2872
File: apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/profile-details-form.tsx:180-189
Timestamp: 2025-09-24T15:50:16.387Z
Learning: TWilson023 prefers to keep security vulnerability fixes separate from refactoring PRs when the vulnerable code is existing and was only moved/relocated rather than newly introduced.