Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(resend): make reply_to snake_case #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
briankerr wants to merge 1 commit into from
Closed

fix(resend): make reply_to snake_case #2929

briankerr wants to merge 1 commit into from

Conversation

@briankerr
Copy link

@briankerr briankerr commented Oct 4, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Corrected email payload to use the proper reply-to format for improved compatibility with the email provider.
    • Ensures replies route correctly while retaining the default support address fallback.
    • No user action required; existing behavior remains unchanged.

@vercel
Copy link
Contributor

vercel bot commented Oct 4, 2025

@briankerr is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 4, 2025 •
edited
Loading

Walkthrough

Renamed the payload field from replyTo to reply_to within resendEmailForOptions in packages/email/src/send-via-resend.ts. The default fallback to "[email protected]" remains unchanged. No other logic, exports, or control flow were modified.

Changes

Cohort / File(s) Summary
Email Resend Payload Update
packages/email/src/send-via-resend.ts		 In resendEmailForOptions, changed payload key replyTo to reply_to. Default fallback behavior unchanged; only the payload property name differs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I twitch my whiskers, tap my paw,
A sly underscore—reply_to—aha!
Bytes hop neatly, fields in line,
Support still answers right on time.
Carrot commits and quiet cheer,
One tiny change, the goal is clear.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely describes the primary change—renaming the reply_to field to snake_case in the resend functionality—using a conventional commit style that accurately reflects the scope of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57259db and cf5b749.

📒 Files selected for processing (1)
  • packages/email/src/send-via-resend.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: TWilson023
PR: dubinc/dub#2835
File: apps/web/ui/analytics/feedback/action.ts:10-13
Timestamp: 2025-09-12T21:08:43.990Z
Learning: In the Dub email system, sendViaNodeMailer is intentionally designed as a simple backup mechanism with hard-coded sender fields, not as a full-featured email sender that preserves all metadata like from/replyTo fields. The primary email path uses Resend for full functionality.
🔇 Additional comments (2)
packages/email/src/send-via-resend.ts (2)

6-42: Verify that CreateEmailOptions declares replyTo
ResendEmailOptions simply extends CreateEmailOptions, so confirm the external type uses camelCase replyTo (not reply_to) to match your mapping; if it doesn’t, update your interface or mapping accordingly.

25-25: Approve snake_case reply_to field change
The Resend HTTP API requires reply_to (snake_case) while its SDKs use replyTo; this update aligns with the official docs.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey
Copy link
Collaborator

steven-tey commented Oct 4, 2025

Thanks @briankerr! Closing this in favor of #2930 🙏

@steven-tey steven-tey closed this Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@briankerr @CLAassistant @steven-tey