Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump resend to latest #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Oct 4, 2025
Merged

Bump resend to latest #2930

steven-tey merged 1 commit into from
Oct 4, 2025

Conversation

@steven-tey
Copy link
Collaborator

@steven-tey steven-tey commented Oct 4, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Standardized the response when the email service is unavailable, returning a consistent empty result instead of undefined to prevent edge-case errors.

  • Refactor

    • Simplified email-sending method signatures by relying on inferred types, reducing noise without changing expected behavior.

  • Chores

    • Updated and reorganized email-related dependencies for improved compatibility and maintenance, including libraries used for sending and templating emails.
    • Adjusted type and build tool declarations to better align with development dependencies.

@vercel
Copy link
Contributor

vercel bot commented Oct 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Oct 4, 2025 6:35am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 4, 2025 •
edited
Loading

Walkthrough

Dependency declarations in the email package were reordered and adjusted in package.json. In code, explicit CreateBatchResponse typings were removed from sendBatchEmail and sendBatchEmailViaResend. The resend guard now returns a concrete { data: null, error: null } object when the client is unavailable.

Changes

Cohort / File(s) Summary of changes
Package metadata updates
packages/email/package.json		 Reordered dependencies/devDependencies; added/updated nodemailer, react-email, resend; adjusted @types placements; moved TypeScript between dependency groups.
Email batch send flow types/behavior
packages/email/src/index.ts, packages/email/src/send-via-resend.ts		 Removed explicit CreateBatchResponse return types and related imports; sendBatchEmail and sendBatchEmailViaResend now rely on inference; no-resend guard returns { data: null, error: null } instead of undefined.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant EmailAPI as index.ts
  participant ResendFlow as send-via-resend.ts
  participant Resend as Resend API

  Caller->>EmailAPI: sendBatchEmail(payload)
  EmailAPI->>ResendFlow: sendBatchEmailViaResend(opts)
  alt Resend client unavailable
    note over ResendFlow: Guard path
    ResendFlow-->>EmailAPI: { data: null, error: null }
  else Resend client available
    ResendFlow->>Resend: createBatch(opts)
    Resend-->>ResendFlow: response
    ResendFlow-->>EmailAPI: response
  end
  EmailAPI-->>Caller: Promise resolving to response
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Fix payout reminder cron #2812 — Alters email package Resend client checks and batch send signatures/returns; overlaps with these signature and guard-path adjustments.
  • Finalize resend package #2463 — Modifies the same email files, adjusting Resend import/types and sendBatchEmail/send-via-resend contracts, closely aligned with this change.

Poem

A bunny taps send with a whisker’s delight,
Types hop away, trimmed light as night.
If Resend naps, we still reply—
Nulls in a basket gently lie.
Carrot-gram queued, ears held high,
Emails leap across the sky.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly identifies the main purpose of the pull request, which is upgrading the Resend dependency to its latest version, and uses clear, concise language without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-resend
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57259db and 418ea86.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • packages/email/package.json (1 hunks)
  • packages/email/src/index.ts (1 hunks)
  • packages/email/src/send-via-resend.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
packages/email/src/index.ts (1)
packages/email/src/resend/types.ts (1)
  • ResendBulkEmailOptions (10-10)
packages/email/src/send-via-resend.ts (1)
packages/email/src/resend/types.ts (1)
  • ResendBulkEmailOptions (10-10)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (5)
packages/email/package.json (2)

14-15: LGTM!

The dependency reordering is cosmetic and doesn't affect functionality.

Also applies to: 19-19, 22-22

16-16: resend version is valid and free of known advisories
Version 6.1.2 exists as the latest stable release and no security vulnerabilities were found.

packages/email/src/index.ts (1)

31-31: LGTM!

Removing the explicit CreateBatchResponse return type annotation and letting TypeScript infer the return type from sendBatchEmailViaResend is a good practice. The inferred type will be correctly derived from the Resend SDK.

packages/email/src/send-via-resend.ts (2)

55-55: LGTM!

Removing the explicit CreateBatchResponse return type annotation allows TypeScript to infer the return type from resend.batch.send(). This is idiomatic and reduces maintenance burden.

56-64: Good improvement: Explicit return object for consistency.

Returning a concrete { data: null, error: null } object instead of undefined when the resend client is unavailable makes the API more consistent and predictable. This matches the expected Resend API response shape and prevents potential type mismatches.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steven-tey steven-tey mentioned this pull request Oct 4, 2025
Closed
@socket-security
Copy link

socket-security bot commented Oct 4, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedresend@​4.0.0 ⏵ 6.1.2100 +2100100 +3100 +1100

View full report

@steven-tey steven-tey merged commit 41ed696 into main Oct 4, 2025
8 of 9 checks passed
@steven-tey steven-tey deleted the bump-resend branch October 4, 2025 06:39
@coderabbitai coderabbitai bot mentioned this pull request Nov 28, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 10, 2025
Closed
@coderabbitai coderabbitai bot mentioned this pull request Dec 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@steven-tey