Upgrade Resend #3170
Upgrade Resend #3170
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/email/src/send-via-resend.ts (1)
53-55: Consider throwing instead of silently sending empty emails.The fallback to
text: ""could mask bugs by sending emails with empty bodies. If this "shouldn't happen in practice," failing early would help catch misuse during development.- // If none of react, html, or text is provided, we need to ensure at least one is present - // This shouldn't happen in practice, but we'll default to an empty text - return { ...baseOptions, text: "" }; + // This shouldn't happen - fail early to catch misuse + throw new Error("Email must have at least one of: react, html, or text");
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/email/src/send-via-resend.ts(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-12T21:08:43.990Z
Learnt from: TWilson023
Repo: dubinc/dub PR: 2835
File: apps/web/ui/analytics/feedback/action.ts:10-13
Timestamp: 2025-09-12T21:08:43.990Z
Learning: In the Dub email system, sendViaNodeMailer is intentionally designed as a simple backup mechanism with hard-coded sender fields, not as a full-featured email sender that preserves all metadata like from/replyTo fields. The primary email path uses Resend for full functionality.
Applied to files:
packages/email/src/send-via-resend.ts
🧬 Code graph analysis (1)
packages/email/src/send-via-resend.ts (2)
packages/email/src/resend/types.ts (1)
ResendEmailOptions(3-8)packages/email/src/resend/constants.ts (1)
VARIANT_TO_FROM_MAP(3-7)
🔇 Additional comments (4)
packages/email/src/send-via-resend.ts (4)
1-1: LGTM!Good use of
import typefor type-only imports, which improves tree-shaking and makes the intent clear.
6-8: LGTM!Explicit return type annotation improves type safety and serves as documentation for consumers of this function.
42-42: LGTM!Clean conditional spreading pattern that avoids including empty or undefined headers.
28-28: Non-null assertion onsubjectmay mask missing subjects.The
subject!assertion bypasses TypeScript's null checks. If a caller accidentally omitssubject, this will silently pass the undefined value to Resend, potentially causing API errors or sending emails without subjects.Consider either:
- Validating
subjectat runtime with a guard- Making
subjectrequired inResendEmailOptionsif it should always be present- subject: subject!, + subject: subject ?? "",Or add validation:
if (!subject) { throw new Error("Email subject is required"); }⛔ Skipped due to learnings
Learnt from: devkiran Repo: dubinc/dub PR: 3113 File: apps/web/app/(ee)/api/cron/payouts/charge-succeeded/send-paypal-payouts.ts:65-75 Timestamp: 2025-11-17T05:19:11.972Z Learning: In the Dub codebase, `sendBatchEmail` (implemented in packages/email/src/send-via-resend.ts) handles filtering of emails with invalid `to` addresses internally. Call sites can safely use non-null assertions on email addresses because the email sending layer will filter out any entries with null/undefined `to` values before sending. This centralized validation pattern is intentional and removes the need for filtering at individual call sites.
Summary by CodeRabbit
Bug Fixes
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.