apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-stats.tsx (1)

95-102: Verify button placement and consider accessibility.

The "Pay out now" button is conditionally rendered inline with the amount display. While the logic is correct (only showing for "Processed" status with amount > 0), consider:

1. The inline placement with ml-2 might cause layout shifts on smaller screens.
2. Adding an aria-label would improve accessibility for screen readers.

Consider this enhancement:

 {label === "Processed" && amount > 0 && (
   <Button
     variant="secondary"
     text="Pay out now"
     className="ml-2 h-7 px-2 py-1"
     onClick={() => setShowForceWithdrawalModal(true)}
+    aria-label="Initiate instant payout for processed funds"
   />
 )}

apps/web/lib/actions/partners/force-withdrawal.ts (1)

35-48: Add check for empty processed payouts.

If there are no processed payouts available, the user will receive a generic "Failed to force withdrawal" error. A more specific error message would improve the user experience.

 const previouslyProcessedPayouts = await prisma.payout.findMany({
   where: {
     partnerId: partner.id,
     status: "processed",
     stripeTransferId: null,
   },
   include: {
     program: {
       select: {
         name: true,
       },
     },
   },
 });

+if (previouslyProcessedPayouts.length === 0) {
+  throw new Error(
+    "No processed payouts available for withdrawal. Please wait for your payouts to be processed.",
+  );
+}
+
 try {

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

packages/email/src/templates/partner-payout-processed.tsx (1)

99-101: Replace hardcoded values with constants.

The hardcoded threshold 1000 and string literals "$10" and "$0.50" should reference MIN_WITHDRAWAL_AMOUNT_CENTS and BELOW_MIN_WITHDRAWAL_FEE_CENTS constants to maintain consistency with the updated values in apps/web/lib/partners/constants.ts.

Apply this diff:

+import { MIN_WITHDRAWAL_AMOUNT_CENTS, BELOW_MIN_WITHDRAWAL_FEE_CENTS } from "@dub/utils";

  {variant === "stripe"
-   ? payout.amount >= 1000
+   ? payout.amount >= MIN_WITHDRAWAL_AMOUNT_CENTS
      ? "The funds will begin transferring to your connected bank account shortly. You will receive another email when the funds are on their way."
-     : "Since this payout is below the minimum withdrawal amount of $10, it will remain in processed status. If you'd like to receive your payout now, you can do so with a $0.50 withdrawal fee."
+     : `Since this payout is below the minimum withdrawal amount of ${currencyFormatter(MIN_WITHDRAWAL_AMOUNT_CENTS / 100, { trailingZeroDisplay: "stripIfInteger" })}, it will remain in processed status. If you'd like to receive your payout now, you can do so with a ${currencyFormatter(BELOW_MIN_WITHDRAWAL_FEE_CENTS / 100, { trailingZeroDisplay: "stripIfInteger" })} withdrawal fee.`
    : "Your payout is on its way to your PayPal account. You'll receive an email from PayPal when it's complete."}

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-stats.tsx (1)

205-247: Fix NaN in currency calculations - critical UX issue.

The calculation of processedPayoutAmountInUsd (lines 206-207) and the modal description amounts (lines 234-236) will produce NaN if payoutStatusMap?.processed?.amount is undefined. This results in user-facing text like "Pay out NaN" and breaks the modal's readability.

Apply safe fallbacks:

 const processedPayoutAmountInUsd = currencyFormatter(
-  payoutStatusMap?.processed?.amount / 100,
+  (payoutStatusMap?.processed?.amount ?? 0) / 100,
   {
     trailingZeroDisplay: "stripIfInteger",
   },
 );

And in the modal description:

         {currencyFormatter(
-          (payoutStatusMap?.processed?.amount -
+          ((payoutStatusMap?.processed?.amount ?? 0) -
             BELOW_MIN_WITHDRAWAL_FEE_CENTS) /
             100,
           { trailingZeroDisplay: "stripIfInteger" },
         )}

apps/web/lib/actions/partners/force-withdrawal.ts (2)

25-33: Clarify rate limit error message.

The error message refers to "retry attempts," but this rate limit applies to force withdrawal initiations, not retries of failed operations. Users will be confused about what action is being limited.

  if (!success) {
    throw new Error(
-      "You've reached the maximum number of retry attempts for the past 24 hours. Please wait and try again later.",
+      "You've reached the maximum number of instant payout requests (5) for the past 24 hours. Please wait and try again later.",
    );
  }

---

50-60: Log the original error before throwing generic message.

The catch block discards the original error, making debugging production issues nearly impossible. The error should be logged with context (partner ID, payout details) before throwing the user-facing message.

  try {
    await createStripeTransfer({
      partner,
      previouslyProcessedPayouts,
      forceWithdrawal: true,
    });
  } catch (error) {
+   console.error(
+     `Force withdrawal failed for partner ${partner.id}:`,
+     error,
+   );
    throw new Error(
      "Failed to force withdrawal. Please try again or contact support.",
    );
  }

apps/web/lib/partners/create-stripe-transfer.ts (1)

88-96: Consider logging withdrawal fee details.

When a withdrawal fee is applied (line 84), the subsequent logs (lines 91-93, 124-129) don't indicate that a fee was deducted. This could make debugging fee-related issues difficult.

Add fee information to the log:

   if (finalTransferableAmount <= 0) {
     console.log(
-      `Final transferable amount after deducting withdrawal fee (${currencyFormatter(finalTransferableAmount / 100)}) is less than or equal to 0, skipping...`,
+      `Final transferable amount (${currencyFormatter(finalTransferableAmount / 100)}) after deducting ${currencyFormatter(withdrawalFee / 100)} fee is less than or equal to 0, skipping...`,
     );

     return;
   }

And enhance the success log around line 124:

   console.log(
-    `Transfer of ${currencyFormatter(finalTransferableAmount / 100)} (${transfer.id}) created for partner ${partner.id} for ${pluralize(
+    `Transfer of ${currencyFormatter(finalTransferableAmount / 100)}${withdrawalFee > 0 ? ` (after ${currencyFormatter(withdrawalFee / 100)} fee)` : ""} (${transfer.id}) created for partner ${partner.id} for ${pluralize(
       "payout",
       allPayouts.length,
     )} ${allPayouts.map((p) => p.id).join(", ")}`,
   );

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/lib/actions/partners/force-withdrawal.ts (4)

29-33: Clarify rate‑limit message to reference instant payout requests.

Current copy says “retry attempts,” which is misleading.

-      throw new Error(
-        "You've reached the maximum number of retry attempts for the past 24 hours. Please wait and try again later.",
-      );
+      throw new Error(
+        "You've reached the maximum number of instant payout requests (5) in the past 24 hours. Please wait and try again later.",
+      );

---

50-60: Log original error for debuggability.

The catch swallows root cause.

 } catch (error) {
-  throw new Error(
+  console.error(`Force withdrawal failed for partner ${partner.id}:`, {
+    error,
+    processedPayoutCount: previouslyProcessedPayouts.length,
+  });
+  throw new Error(
     "Failed to force withdrawal. Please try again or contact support.",
   );
 }

---

35-48: Guard empty processed payouts to avoid false “success.”

If none exist, the transfer call is a no‑op and the UI shows a success toast.

   const previouslyProcessedPayouts = await prisma.payout.findMany({
@@
   });
 
+  if (previouslyProcessedPayouts.length === 0) {
+    throw new Error("No processed payouts found to withdraw.");
+  }

---

50-56: Surface transfer outcome; don’t toast success on no‑op.

createStripeTransfer can early‑return (e.g., final amount ≤ 0) without throwing, but this action treats it as success. Make the helper return a boolean and act accordingly.

-    try {
-      await createStripeTransfer({
+    try {
+      const transferred = await createStripeTransfer({
         partner,
         previouslyProcessedPayouts,
         forceWithdrawal: true,
       });
+      if (!transferred) {
+        throw new Error("Nothing to transfer.");
+      }

Follow-up change needed in create-stripe-transfer.ts to return boolean; see related comment. Based on learnings.

packages/email/src/templates/partner-payout-processed.tsx (1)

98-101: Replace hardcoded $10 / $0.50 and 1000 with shared constants.

Use MIN_WITHDRAWAL_AMOUNT_CENTS and BELOW_MIN_WITHDRAWAL_FEE_CENTS with currencyFormatter for consistency and single‑source‑of‑truth.

@@
-              {variant === "stripe"
-                ? payout.amount >= 1000
-                  ? "The funds will begin transferring to your connected bank account shortly. You will receive another email when the funds are on their way."
-                  : "Since this payout is below the minimum withdrawal amount of $10, it will remain in processed status. If you'd like to receive your payout now, you can do so with a $0.50 withdrawal fee."
+              {variant === "stripe"
+                ? payout.amount >= MIN_WITHDRAWAL_AMOUNT_CENTS
+                  ? "The funds will begin transferring to your connected bank account shortly. You will receive another email when the funds are on their way."
+                  : `Since this payout is below the minimum withdrawal amount of ${currencyFormatter(
+                      MIN_WITHDRAWAL_AMOUNT_CENTS / 100,
+                      { trailingZeroDisplay: "stripIfInteger" },
+                    )}, it will remain in processed status. If you'd like to receive your payout now, you can do so with a ${currencyFormatter(
+                      BELOW_MIN_WITHDRAWAL_FEE_CENTS / 100,
+                      { trailingZeroDisplay: "stripIfInteger" },
+                    )} withdrawal fee.`
                 : "Your payout is on its way to your PayPal account. You'll receive an email from PayPal when it's complete."}

Add import at top (if not already exported here, re‑export from @dub/utils as a follow‑up):

+import { MIN_WITHDRAWAL_AMOUNT_CENTS, BELOW_MIN_WITHDRAWAL_FEE_CENTS } from "@dub/utils";

Please confirm these constants are exported from @dub/utils for the email package; if not, move them to @dub/utils (or re-export) to avoid apps/web cross‑package coupling.

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-stats.tsx (1)

93-103: Fix NaN risk, correct copy, show net amount, and gate button appropriately.

• Use null‑safe amounts to avoid NaN in currencyFormatter.
• If processed ≥ MIN, no fee and copy should not claim “below minimum.”
• Confirm button should show the net amount when fee applies.
• Disable actions while pending; refresh stats after success.

-              {label === "Processed" && amount > 0 && (
+              {label === "Processed" && amount > 0 && amount < MIN_WITHDRAWAL_AMOUNT_CENTS && (
                 <Button
                   variant="secondary"
                   text="Pay out now"
                   className="ml-2 h-7 px-2 py-1"
                   onClick={() => setShowForceWithdrawalModal(true)}
                 />
               )}
@@
-  const { executeAsync: executeForceWithdrawal } = useAction(
+  const { executeAsync: executeForceWithdrawal, isPending: isWithdrawing } = useAction(
     forceWithdrawalAction,
     {
       onSuccess: () => {
         toast.success("Withdrawal initiated successfully");
+        // TODO: revalidate payout counts; replace key with the one used by usePartnerPayoutsCount
+        // mutatePrefix("/api/partner-payouts");
       },
       onError: ({ error }) => {
         toast.error(error.serverError || "Failed to initiate withdrawal");
       },
     },
   );
 
-  const processedPayoutAmountInUsd = currencyFormatter(
-    payoutStatusMap?.processed?.amount / 100,
+  const processedAmountCents = payoutStatusMap?.processed?.amount ?? 0;
+  const isBelowMin = processedAmountCents > 0 && processedAmountCents < MIN_WITHDRAWAL_AMOUNT_CENTS;
+  const netAmountCents = isBelowMin
+    ? Math.max(processedAmountCents - BELOW_MIN_WITHDRAWAL_FEE_CENTS, 0)
+    : processedAmountCents;
+  const processedPayoutAmountInUsd = currencyFormatter(
+    processedAmountCents / 100,
     {
       trailingZeroDisplay: "stripIfInteger",
     },
   );
+  const netPayoutAmountInUsd = currencyFormatter(netAmountCents / 100, {
+    trailingZeroDisplay: "stripIfInteger",
+  });
@@
   } = useConfirmModal({
     title: "Pay out funds instantly",
-    description: (
+    description: (
       <>
-        Since your total processed earnings (
-        <strong className="text-black">{processedPayoutAmountInUsd}</strong>)
-        are below the minimum requirement of{" "}
-        <strong className="text-black">
-          {currencyFormatter(MIN_WITHDRAWAL_AMOUNT_CENTS / 100, {
-            trailingZeroDisplay: "stripIfInteger",
-          })}
-        </strong>
-        , you will be charged a fee of{" "}
-        <strong className="text-black">
-          {currencyFormatter(BELOW_MIN_WITHDRAWAL_FEE_CENTS / 100)}
-        </strong>{" "}
-        for this payout, which means you will receive{" "}
-        <strong className="text-black">
-          {currencyFormatter(
-            (payoutStatusMap?.processed?.amount -
-              BELOW_MIN_WITHDRAWAL_FEE_CENTS) /
-              100,
-            { trailingZeroDisplay: "stripIfInteger" },
-          )}
-        </strong>
-        .
+        {isBelowMin ? (
+          <>
+            Since your total processed earnings (
+            <strong className="text-black">{processedPayoutAmountInUsd}</strong>
+            ) are below the minimum requirement of{" "}
+            <strong className="text-black">
+              {currencyFormatter(MIN_WITHDRAWAL_AMOUNT_CENTS / 100, {
+                trailingZeroDisplay: "stripIfInteger",
+              })}
+            </strong>
+            , a{" "}
+            <strong className="text-black">
+              {currencyFormatter(BELOW_MIN_WITHDRAWAL_FEE_CENTS / 100)}
+            </strong>{" "}
+            fee will apply. You will receive{" "}
+            <strong className="text-black">{netPayoutAmountInUsd}</strong>.
+          </>
+        ) : (
+          <>
+            Your processed earnings (
+            <strong className="text-black">{processedPayoutAmountInUsd}</strong>
+            ) will be paid out now. No fee applies.
+          </>
+        )}
       </>
     ),
     onConfirm: async () => {
-      await executeForceWithdrawal();
+      await executeForceWithdrawal();
     },
-    confirmText: `Pay out ${processedPayoutAmountInUsd}`,
+    confirmText: `Pay out ${isBelowMin ? netPayoutAmountInUsd : processedPayoutAmountInUsd}`,
+    confirmDisabled: isWithdrawing,
   });

Optionally, pass loading/disabled to the “Pay out now” button using isWithdrawing. Based on learnings.

Also applies to: 193-247

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx (2)

189-197: Remove unnecessary flexbox classes or clarify intent.

The wrapper div uses justify-between with only a single child (Filter.Select). Flexbox properties like justify-between, items-center, and gap-2 have no effect with a single child element.

If no additional elements are planned, simplify to:

-<div className="flex items-center justify-between gap-2">
-  <Filter.Select
-    className="w-full md:w-fit"
-    filters={filters}
-    activeFilters={activeFilters}
-    onSelect={onSelect}
-    onRemove={onRemove}
-  />
-</div>
+<Filter.Select
+  className="w-full md:w-fit"
+  filters={filters}
+  activeFilters={activeFilters}
+  onSelect={onSelect}
+  onRemove={onRemove}
+/>

Otherwise, if additional UI elements (e.g., action buttons) are planned for this row, please clarify with a comment.

---

40-40: Destructure error from usePartnerPayoutsCount for consistency and visibility.

The hook returns { payoutsCount, error, loading }, but only payoutsCount is destructured. While the Table component safely handles undefined rowCount via its !!rowCount check, other files using this hook (e.g., payout-stats.tsx) destructure the error state. This pattern inconsistency masks potential API failures silently.

Recommendation: Align with the pattern used in payout-stats.tsx by adding:

const { payoutsCount, error } = usePartnerPayoutsCount<number>();

This improves error visibility for debugging and maintains consistency across the codebase.

packages/email/src/templates/partner-payout-processed.tsx (1)

44-46: Nit: rename saleAmountInDollars for clarity.

It’s a payout amount, not sale amount.

-const saleAmountInDollars = currencyFormatter(payout.amount / 100, {
+const payoutAmountInUsd = currencyFormatter(payout.amount / 100, {
   trailingZeroDisplay: "stripIfInteger",
 });
@@
-<strong className="text-black">{saleAmountInDollars}</strong>
+<strong className="text-black">{payoutAmountInUsd}</strong>

Also applies to: 84-85

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/partner-payout-settings-sheet.tsx (3)

16-17: Avoid deep import; use stable utils surface.

Import COUNTRY_CURRENCY_CODES from @dub/utils, not @dub/utils/src, to prevent bundling/resolution issues.

-import { CONNECT_SUPPORTED_COUNTRIES, COUNTRIES } from "@dub/utils";
-import { COUNTRY_CURRENCY_CODES } from "@dub/utils/src";
+import { CONNECT_SUPPORTED_COUNTRIES, COUNTRIES, COUNTRY_CURRENCY_CODES } from "@dub/utils";

---

61-73: Keep form in sync with async partner data; remove unused vars.

defaultValues are only used on mount; without reset the form can render stale/empty values. Also watch and setValue are unused.

-  const {
-    register,
-    handleSubmit,
-    watch,
-    setValue,
-    formState: { isDirty },
-  } = useForm<PartnerPayoutSettingsFormData>({
+  const {
+    register,
+    handleSubmit,
+    reset,
+    formState: { isDirty },
+  } = useForm<PartnerPayoutSettingsFormData>({
     defaultValues: {
       companyName: partner?.companyName || undefined,
       address: partner?.invoiceSettings?.address || undefined,
       taxId: partner?.invoiceSettings?.taxId || undefined,
     },
   });
+
+  // Sync when partner loads/changes
+  useEffect(() => {
+    if (!partner) return;
+    reset({
+      companyName: partner.companyName || undefined,
+      address: partner.invoiceSettings?.address || undefined,
+      taxId: partner.invoiceSettings?.taxId || undefined,
+    });
+  }, [partner, reset]);

---

226-232: Disable Save while pending.

Prevent double submits.

-        <Button
+        <Button
           text="Save"
           className="h-8 w-fit px-3"
           loading={isPending}
-          disabled={!isDirty}
+          disabled={isPending || !isDirty}
           type="submit"
         />

apps/web/lib/partners/create-stripe-transfer.ts (1)

102-122: Guard invoiceId presence and return true on success.

Avoid non‑null assertion risk; finish with an explicit true.

-  const finalPayoutInvoiceId = allPayouts[allPayouts.length - 1].invoiceId;
+  const finalPayoutInvoiceId = allPayouts[allPayouts.length - 1].invoiceId;
+  if (!finalPayoutInvoiceId) {
+    console.log(`Missing invoiceId on payouts for partner ${partner.id}, skipping...`);
+    return false;
+  }
@@
-  const transfer = await stripe.transfers.create(
+  const transfer = await stripe.transfers.create(
     {
       amount: finalTransferableAmount,
       currency: "usd",
@@
-      transfer_group: finalPayoutInvoiceId!,
+      transfer_group: finalPayoutInvoiceId,
@@
   );
@@
   await Promise.allSettled([
@@
   ]);
+  return true;

Also applies to: 124-156

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-stats.tsx (1)

16-17: Optional: allow instant payout even when ≥ min (if intended).

If you want the button always visible, keep the button condition but use the modal copy above (no fee when ≥ min). Otherwise, gating to < MIN (diff above) matches current copy.

Confirm the intended UX: Should “Pay out now” be offered when processed ≥ minimum (to avoid waiting background runs)?

Also applies to: 96-102

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro