Update payout pending status descriptions #3216

marcusljf · 2025-12-10T23:19:39Z

Clarified the 'pending' payout status descriptions for both Stripe and PayPal to indicate that payouts may not have met the program minimum.

Summary by CodeRabbit

Bug Fixes
- Clarified pending and processed payout descriptions for Stripe and PayPal to include links, reference the holding period, and note that the program minimum payout must be met before release.
UI
- Updated amount tooltip and pending-badge tooltip to surface the minimum payout link and improve numeric display handling (trim trailing zeros).

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Clarified the 'pending' payout status descriptions for both Stripe and PayPal to indicate that payouts may not have met the program minimum. Removed reference to the program's holding period for improved clarity.

vercel · 2025-12-10T23:19:44Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
dub	Ready	Preview	Dec 14, 2025 0:37am

coderabbitai · 2025-12-10T23:19:54Z

Walkthrough

Updated tooltip and pending-status copy for partner payouts to add hyperlinks to help docs and explicitly reference the minimum payout/withdrawal amount; no control-flow, API, or export signatures were changed.

Changes

Cohort / File(s)	Change Summary
Payout status descriptions `apps/web/ui/partners/payout-status-descriptions.ts`	Updated pending descriptions for Stripe and PayPal to include hyperlink(s) to the holding-period/help article and add a note that the minimum payout amount must be met.
Payout table tooltip `apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx`	Rewrote tooltip copy to reference the minimum payout amount via a linked phrase, removed a separate "Learn more." link, and added `trailingZeroDisplay: "stripIfInteger"` to the Tooltip props.
Payout status badge tooltip `apps/web/ui/partners/payout-status-badge-partner.tsx`	Adjusted pending tooltip copy to include a linked phrase referencing the minimum payout amount; no logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Check copy and hyperlink URLs for accuracy.
Verify tooltip prop addition (trailingZeroDisplay) doesn't conflict with existing Tooltip behavior or typings.
Confirm no unintended modifications to other status texts or exports.

Possibly related PRs

Add Instant payouts feature #2984 — Modifies the same payout UI files and references the minimum payout amount/formatter; likely directly related.

Poem

🐰
I hopped through lines of copy bright and neat,
Linked helpful pages and made the message sweet.
Minimums mentioned, clarity in sight,
Payouts now speak plainly — cozy and right. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update payout pending status descriptions' directly and clearly describes the main change across all three modified files, which all involve updating payout status descriptions.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch pending-tooltip

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5fcbbd2 and b5672ea.

📒 Files selected for processing (3)

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx (1 hunks)
apps/web/ui/partners/payout-status-badge-partner.tsx (1 hunks)
apps/web/ui/partners/payout-status-descriptions.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/web/ui/partners/payout-status-descriptions.ts

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-05-29T04:45:18.504Z

Learnt from: devkiran
Repo: dubinc/dub PR: 2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.

Applied to files:

apps/web/ui/partners/payout-status-badge-partner.tsx

🧬 Code graph analysis (2)

apps/web/ui/partners/payout-status-badge-partner.tsx (1)

packages/utils/src/functions/currency-formatter.ts (1)

currencyFormatter (7-22)

apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx (1)

packages/utils/src/functions/currency-formatter.ts (1)

currencyFormatter (7-22)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

🔇 Additional comments (1)

apps/web/ui/partners/payout-status-badge-partner.tsx (1)

33-36: The Tooltip component from @dub/ui fully supports Markdown rendering. When content is passed as a string (as in this case at lines 33-36), the component automatically processes it through ReactMarkdown, which properly renders the Markdown link syntax. The help article URL is also accessible and returns HTTP 200. No changes are needed.

Likely an incorrect or invalid review comment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/web/ui/partners/payout-status-descriptions.ts (1)

6-8: Pending copy update looks good; consider aligning terminology with “minimum withdrawal amount” (optional).

The new wording for both Stripe and PayPal pending statuses clearly adds the “may not have met the program minimum” caveat and matches the PR intent. One minor nit: elsewhere (e.g., the processed description) you refer to the threshold as the “minimum withdrawal amount” with a specific value; if “program minimum” is the same concept, you might consider reusing the same term for consistency, or intentionally differentiate it in product copy somewhere. No changes required if this terminology difference is deliberate.

Also applies to: 17-19

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a32eac and 5fcbbd2.

📒 Files selected for processing (1)

apps/web/ui/partners/payout-status-descriptions.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

Update payout pending status descriptions

5fcbbd2

Clarified the 'pending' payout status descriptions for both Stripe and PayPal to indicate that payouts may not have met the program minimum. Removed reference to the program's holding period for improved clarity.

coderabbitai bot reviewed Dec 10, 2025

View reviewed changes

vercel bot deployed to Preview December 10, 2025 23:25 View deployment

steven-tey added 2 commits December 13, 2025 16:19

Merge branch 'main' into pending-tooltip

403cce8

finalize status tooltips

b5672ea

steven-tey approved these changes Dec 14, 2025

View reviewed changes

vercel bot deployed to Preview December 14, 2025 00:37 View deployment

steven-tey merged commit abdb168 into main Dec 14, 2025
7 of 8 checks passed

steven-tey deleted the pending-tooltip branch December 14, 2025 00:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update payout pending status descriptions #3216

Update payout pending status descriptions #3216

marcusljf commented Dec 10, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update payout pending status descriptions #3216

Update payout pending status descriptions #3216

Conversation

marcusljf commented Dec 10, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marcusljf commented Dec 10, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Dec 10, 2025 •

edited

Loading

coderabbitai bot commented Dec 10, 2025 •

edited

Loading