[comments] Do not exclude tests globally #3801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3801 +/- ##
=========================================
Coverage 83.39% 83.39%
Complexity 2902 2902
=========================================
Files 453 453
Lines 8739 8739
Branches 1665 1665
=========================================
Hits 7288 7288
Misses 550 550
Partials 901 901 Continue to review full report at Codecov.
|
BraisGabin
approved these changes
May 20, 2021
schalkms
approved these changes
May 20, 2021
This was referenced May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3777
For the
commentsruleset, we were ignoring tests at the ruleset level. I believe we can apply the excludes only on rules where it really makes sense:UndocumentedPublicClass,UndocumentedPublicFunction,UndocumentedPublicProperty