Properly apply test excludes for comments #3815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3815 +/- ##
=========================================
Coverage 83.58% 83.58%
- Complexity 3055 3059 +4
=========================================
Files 456 456
Lines 8916 8924 +8
Branches 1752 1752
=========================================
+ Hits 7452 7459 +7
- Misses 541 542 +1
Partials 923 923
Continue to review full report at Codecov.
|
marschwar
approved these changes
May 22, 2021
BraisGabin
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3812
My original PR #3801 was wrong. The correct way to apply excludes is to list them inside the
Exclusion.ktfile.