fix(node): refactor and consolidate grub #2 #5437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
commented
Jun 5, 2025
f174481 to
bbfb096
Compare
|
Fixed backwards compatibility bug: bbfb096 I've created a ticket to remove all the backwards compatibility: https://dfinity.atlassian.net/browse/NODE-1620 |
Bownairo
reviewed
Jun 6, 2025
Bownairo
approved these changes
Jun 6, 2025
basvandijk
added a commit
that referenced
this pull request
Jun 6, 2025
andrewbattat
added a commit
that referenced
this pull request
Jun 6, 2025
basvandijk
added a commit
that referenced
this pull request
Jun 6, 2025
) This reverts commit 6446247 since it breaks the`//rs/tests/nested:registration` test ([BuildBuddy](https://dash.zh1-idx1.dfinity.network/invocation/7daaa936-92fa-40c6-bb44-a7405d0a7192?target=%2F%2Frs%2Ftests%2Fnested%3Aregistration&targetStatus=6)).
Bownairo
pushed a commit
that referenced
this pull request
Jun 9, 2025
https://dfinity.atlassian.net/browse/NODE-1619 bbfb096 - Fix grub backwards compatibility by continuing to pass extra_boot_args d7533c0 - Create boot_args.template for hostos and guestos ba50c70 - Create requires_root_signing bool 9e7d432 - Move boot_args.template files to bootloader/
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
Following #5437 and #5455, with additional changes only to fix test driver and update docs ([compare](https://github.com/dfinity/ic/pull/5462/files/ac5816f8b6fb19d7aa527728cdafac696c086cd3..1070935f0f31b9fa9fdcd69a3ff0ef34ffbd6fe2)). --------- Co-authored-by: Andrew Battat <[email protected]> Co-authored-by: Bas van Dijk <[email protected]>
aterga
pushed a commit
that referenced
this pull request
Jun 17, 2025
Following #5437 and #5455, with additional changes only to fix test driver and update docs ([compare](https://github.com/dfinity/ic/pull/5462/files/ac5816f8b6fb19d7aa527728cdafac696c086cd3..1070935f0f31b9fa9fdcd69a3ff0ef34ffbd6fe2)). --------- Co-authored-by: Andrew Battat <[email protected]> Co-authored-by: Bas van Dijk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dfinity.atlassian.net/browse/NODE-1619
bbfb096 - Fix grub backwards compatibility by continuing to pass extra_boot_args
d7533c0 - Create boot_args.template for hostos and guestos
ba50c70 - Create requires_root_signing bool
9e7d432 - Move boot_args.template files to bootloader/