-
Notifications
You must be signed in to change notification settings - Fork 365
test this #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
test this #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfinity-bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
lint: add a negative dependency checker Add a program that looks for undesired dependencies in the workspace dependency graph. Example output: ``` Found 3 dependency policy violations. ================================================================================ Found a violation of rule #1 defined in depcheck/src/main.rs: ================================================================================ '*' should not depend on 'git2'. If you need to get data from Git, consider executing 'git' command as a subprocess. 'git2' requires native libraries and increases compile time by ~10s, usually providing little value. Shortest dependency path: depcheck:0.1.0 └── git2:0.7.2 ================================================================================ Found a violation of rule #2 defined in depcheck/src/main.rs: ================================================================================ 'ic-replica' should not depend on 'dfn_core'. Replica must not depend on Rust CDK. Shortest dependency path: ic-replica:0.8.0 └── ic-crypto:0.8.0 └── ic-crypto-tls-cert-validation:0.8.0 └── dfn_core:0.8.0 ================================================================================ Found a violation of rule #3 defined in depcheck/src/main.rs: ================================================================================ 'ic-interfaces' should not depend on 'tokio'. Interfaces should not depend on implementation details. Shortest dependency path: ic-interfaces:0.8.0 └── tokio:1.17.0 ``` See merge request dfinity-lab/public/ic!3524
gitlab-dfinity
pushed a commit
that referenced
this pull request
Mar 3, 2023
…aster' perf: [EXC-1119] optimise Scheduler::execute_round by removing excessive canister state lookups This MR removes an extra lookups for canister state and metric updates. Optimisation #1. Canister metric update. Before this MR in order to record the metric there is a loop that iterates over all the canister IDs, looks up their state in states and modifies the state. When the number of canisters is big then the lookup introduces a significant factor to an O(n) iteration. Eg. for a subnet with 100k total and 100 active canisters it might be ~10% of `execute_round` function time. This MR moves the metric update to the already existing loop with a lookup in a previous step `apply_scheduling_strategy`. Optimisation #2. Canister state update. Both `canister_states` and `round_states` contain the elements in the same order, but when iterating over `round_states` it requires to do an expensive canister state lookup. The optimisation iterates over those two collections simultaneously (relying on the same elements order) which get the canister state for free. On a testnet with 100k total and 100 active canisters this optimisation saves 4.8-5.2% of DSM critical path (scheduling step, no optimisation 7.5-8.2%, with optimisation 2.7-3%). See merge request dfinity-lab/public/ic!11052
gitlab-dfinity
pushed a commit
that referenced
this pull request
May 3, 2023
… 'master' feat(crypto) CRP-1894: Zeroize old secret key store when writing new content The way the SKS is currently updated is as follows: 1. On startup, the SKS is read from disk, and maintained in memory. 2. If changes are made to the SKS (new key generated, old key deleted), the changes are made in memory, and then written to disk. The writing to disk is performed as follows: 1. Write the updated SKS to a new, temporary file. 2. Atomically replace the existing SKS by moving/renaming the new SKS to the location of the existing SKS. To zeroize the old SKS, the proposed approach when writing the new SKS to disk is as follows: 1. Create a hard link to the old SKS - same path and filename, but with “.old” suffix 2. Write the new SKS to disk using the temporary file and rename to replace the existing SKS as above. 3. Zeroize the old SKS file using the hard link created in step #1. 4. Remove the hard link created in step #1. In case the node/process crashes while writing the new SKS (in practice, somewhere after step #1 but before step #4), some cleanup needs to be done: - If the crash happened after #1 but before #2, the hard link with the “.old” suffix will point to the current SKS - in this case, simply remove the hard link to the SKS, but do not zeroize it. - If the crash happened after #2, perform steps #3 and #4 from above (zeroize the old file and delete it). The cleanup can be done when opening the SKS to read it. To determine which of the two cleanup actions should be done, check to see if a hard link with “.old” suffix exists, and if so, if it points to the same file (inode) as the current SKS - if yes, zeroize and delete the “.old” file; if no, simply delete the “.old” file. One scenario where this zeroization introduces a new security exposure is in case we crash between steps #2 and #3 above, where the new keystore has been written, but there is still a hard link to the old keystore, and the old keystore has not been zeroized. See merge request dfinity-lab/public/ic!10724
massimoalbarello
referenced
this pull request
Feb 10, 2024
gitlab-dfinity
pushed a commit
that referenced
this pull request
Apr 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
#977) This PR is the first step towards enabling the `SnsW.get_wasm_metadata` endpoint in production. For that, we need a way to store the metadata in the stable memory, as recomputing it each time is expensive (because canister WASMs stored in SNS-W are often compressed). Unlike the [first attempt](#956), this PR makes it harder to represent disallowed states in the type system, e.g., there cannot metadata that does not belong to any WASM stored in SNS-W. --------- Co-authored-by: IDX GitHub Automation <[email protected]> Co-authored-by: Carly Gundy <[email protected]> Co-authored-by: Mathias Björkqvist <[email protected]> Co-authored-by: tim gretler <[email protected]>
gbrel
added a commit
that referenced
this pull request
Mar 28, 2025
gbrel
added a commit
that referenced
this pull request
Apr 22, 2025
…_total_size_too_large more similar
gbrel
added a commit
that referenced
this pull request
May 15, 2025
gbrel
added a commit
that referenced
this pull request
May 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
https://dfinity.atlassian.net/browse/NODE-1619 bbfb096 - Fix grub backwards compatibility by continuing to pass extra_boot_args d7533c0 - Create boot_args.template for hostos and guestos ba50c70 - Create requires_root_signing bool 9e7d432 - Move boot_args.template files to bootloader/
basvandijk
added a commit
that referenced
this pull request
Jun 6, 2025
andrewbattat
added a commit
that referenced
this pull request
Jun 6, 2025
basvandijk
added a commit
that referenced
this pull request
Jun 6, 2025
) This reverts commit 6446247 since it breaks the`//rs/tests/nested:registration` test ([BuildBuddy](https://dash.zh1-idx1.dfinity.network/invocation/7daaa936-92fa-40c6-bb44-a7405d0a7192?target=%2F%2Frs%2Ftests%2Fnested%3Aregistration&targetStatus=6)).
Bownairo
pushed a commit
that referenced
this pull request
Jun 9, 2025
https://dfinity.atlassian.net/browse/NODE-1619 bbfb096 - Fix grub backwards compatibility by continuing to pass extra_boot_args d7533c0 - Create boot_args.template for hostos and guestos ba50c70 - Create requires_root_signing bool 9e7d432 - Move boot_args.template files to bootloader/
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
Following #5437 and #5455, with additional changes only to fix test driver and update docs ([compare](https://github.com/dfinity/ic/pull/5462/files/ac5816f8b6fb19d7aa527728cdafac696c086cd3..1070935f0f31b9fa9fdcd69a3ff0ef34ffbd6fe2)). --------- Co-authored-by: Andrew Battat <[email protected]> Co-authored-by: Bas van Dijk <[email protected]>
aterga
pushed a commit
that referenced
this pull request
Jun 17, 2025
Following #5437 and #5455, with additional changes only to fix test driver and update docs ([compare](https://github.com/dfinity/ic/pull/5462/files/ac5816f8b6fb19d7aa527728cdafac696c086cd3..1070935f0f31b9fa9fdcd69a3ff0ef34ffbd6fe2)). --------- Co-authored-by: Andrew Battat <[email protected]> Co-authored-by: Bas van Dijk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.