-
Notifications
You must be signed in to change notification settings - Fork 68
Switch of AOD and RECO for AlCaLumiPixelsCountsPrompt #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
test syntax please |
|
Thanks for the changes @tvami . I deployed a replay with your configuration with the run 352929. The output data is the following: Could you confirm that the data generated is as expected in order to move those changes to the production config? |
|
Thanks @jhonatanamado I confirm that's the expected output. |
|
@tvami following also a question got at the daily run meeting: are these workflows supposed to be re-enabled later on? So is this a temporary update of the configuration? |
|
@fabiocos as far as I understood from Lumi experts: no these are not supposed to be re-enabled later. |
|
ok, thanks you |
|
Hi - So we are reverting the config defined a month ago or I’m just wrong ?
#4678 (comment)
Thanks,
Gaelle
On 22 Jun 2022, at 10:40, francescobrivio ***@***.******@***.***>> wrote:
@fabiocos<https://github.com/fabiocos> as far as I understood from Lumi experts: no these are not supposed to be re-enabled later.
They are just not needed and it was forgotten to "switch them off" earlier.
—
Reply to this email directly, view it on GitHub<#4699 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHE3SFPYIYIWIAJ5QGTUOLVQLGQZANCNFSM5ZNYYAXQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Hi Gaelle, not fully, I keep the |
|
Hi @boudoul, |
|
OK thanks for the clarification !
On 22 Jun 2022, at 11:58, francescobrivio ***@***.******@***.***>> wrote:
Hi @boudoul<https://github.com/boudoul>,
my comment that you mention (#4678 (comment)<#4678 (comment)>) was based on the changes that we tested in the replay in preparation for Run3 collisions (#4677<#4677>), which turns out was not correct in the first place for this special case, as write_reco and write_aod should have always been Falsefrom the beginning for the "AlCaLumiPixelsCountsPrompt* PDs. My mistake!
—
Reply to this email directly, view it on GitHub<#4699 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHE3SDJYQTMRY3QHUFONELVQLPULANCNFSM5ZNYYAXQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
71e3caf to
ea54fd2
Compare
These datasets are being produced
/AlCaLumiPixelsCountsPrompt/Run2022A-PromptReco-v1/RECO
/AlCaLumiPixelsCountsPrompt/Run2022A-PromptReco-v1/AOD
and have zero content (as expected). Apparently we just forgot to switch them off, so this PR does that.