Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tvami
Copy link
Contributor

@tvami tvami commented Jun 21, 2022

These datasets are being produced
/AlCaLumiPixelsCountsPrompt/Run2022A-PromptReco-v1/RECO

/AlCaLumiPixelsCountsPrompt/Run2022A-PromptReco-v1/AOD

and have zero content (as expected). Apparently we just forgot to switch them off, so this PR does that.

@tvami
Copy link
Contributor Author

tvami commented Jun 21, 2022

test syntax please

@jhonatanamado
Copy link
Contributor

jhonatanamado commented Jun 22, 2022

Thanks for the changes @tvami . I deployed a replay with your configuration with the run 352929. The output data is the following:

/AlCaLumiPixelsCountsPrompt/Tier0_REPLAY_2022-v434/RAW#09a952df-a4b8-470f-965c-caadef03e67d
/AlCaLumiPixelsCountsPrompt/Tier0_REPLAY_2022-AlCaPCCZeroBias-PromptReco-v434/ALCARECO#d844f1d4-1eb7-4e49-9e66-7c8224cfc251
/AlCaLumiPixelsCountsPrompt/Tier0_REPLAY_2022-RawPCCProducer-PromptReco-v434/ALCARECO#2cf92aa8-1366-4ea4-bf89-6960685380e7

Could you confirm that the data generated is as expected in order to move those changes to the production config?

@tvami
Copy link
Contributor Author

tvami commented Jun 22, 2022

Thanks @jhonatanamado I confirm that's the expected output.

@fabiocos
Copy link
Contributor

@tvami following also a question got at the daily run meeting: are these workflows supposed to be re-enabled later on? So is this a temporary update of the configuration?

@francescobrivio
Copy link
Contributor

@fabiocos as far as I understood from Lumi experts: no these are not supposed to be re-enabled later.
They are just not needed and it was forgotten to "switch them off" earlier.

@fabiocos
Copy link
Contributor

ok, thanks you

@boudoul
Copy link

boudoul commented Jun 22, 2022 via email

@tvami
Copy link
Contributor Author

tvami commented Jun 22, 2022

Hi Gaelle, not fully, I keep the do_reco still to be true and the output to CERN T2 sounds good as well, but the point is that we only need the ALCARECO... I let Francesco comment about the request to have the RECO and AOD output to be true in the comment you were referring to.

@francescobrivio
Copy link
Contributor

francescobrivio commented Jun 22, 2022

Hi @boudoul,
my comment that you mention (#4678 (comment)) was based on the changes that we tested in the replay in preparation for Run3 collisions (#4677), which turns out was not correct in the first place for this special case, as write_reco and write_aod should have always been False from the beginning for the AlCaLumiPixelsCountsPrompt* PDs. My mistake!

@boudoul
Copy link

boudoul commented Jun 22, 2022 via email

@tvami tvami force-pushed the ChangeLumiPCCSettings branch from 71e3caf to ea54fd2 Compare June 22, 2022 13:48
@jhonatanamado jhonatanamado merged commit c2cce2a into dmwm:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants