Extensions: fix betterness with params and issues with this modifier
#80531
+268
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
approved these changes
Oct 3, 2025
AlekseyTs
reviewed
Oct 3, 2025
| // Method begins at RVA 0x206f | ||
| // Code size 14 (0xe) | ||
| // Method begins at RVA 0x2050 | ||
| // Code size 7 (0x7) |
Contributor
AlekseyTs
reviewed
Oct 3, 2025
| .get instance string System.Runtime.CompilerServices.ExtensionMarkerAttribute::get_Name() | ||
| } | ||
| } // end of class System.Runtime.CompilerServices.ExtensionMarkerAttribute | ||
| """.Replace("[mscorlib]", ExecutionConditionUtil.IsMonoOrCoreClr ? "[netstandard]" : "[mscorlib]")); |
Contributor
AlekseyTs
reviewed
Oct 3, 2025
| ) | ||
| // Fields | ||
| .field private initonly string '<Name>k__BackingField' | ||
| // Methods |
Contributor
AlekseyTs
reviewed
Oct 3, 2025
|
|
||
| var type = parameter.Type; | ||
| if (memberResolutionResult.Kind == MemberResolutionKind.ApplicableInExpandedForm && | ||
| parameter.Ordinal == parameters.Length - 1) |
Contributor
Member
Author
There was a problem hiding this comment.
I reviewed all the usages of Ordinal. Added some tests for that in last commit and fixed handling of this modifier.
Contributor
|
Done with review pass (commit 1) #Closed |
this modifier
This was referenced Oct 16, 2025
This was referenced Oct 18, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80512
Relates to test plan #76130