Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[main] Source code updates from dotnet/roslyn #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dotnet-maestro wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[main] Source code updates from dotnet/roslyn #3957

dotnet-maestro wants to merge 10 commits into from
+103,043 −22,842

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 18, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/roslyn

Diff the source with this PR branch 
darc vmr diff --name-only https://github.com/dotnet/roslyn:bf35fe58e593ac0ac74c05bfa6e4719b85772da0..https://github.com/dotnet/dotnet:darc-main-32ed21f9-cfdb-4a1a-9319-fb046bfdd2dc

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Dec 18, 2025 •
edited by premun
Loading

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Dec 19, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 19, 2025

@jjonescz this one is now up-to-date and doesn't show the previous issue anymore. But there are new issues:

CSC : error CS1566: Error reading resource 'Microsoft.VisualStudio.IntegrationTestService.vsix' -- 'Could not find a part of the path 'D:\a_work\1\s\src\roslyn\artifacts\VSSetup\Release\Microsoft.VisualStudio.IntegrationTestService.vsix'.' [D:\a_work\1\s\src\roslyn\src\VisualStudio\IntegrationTest\Harness\XUnit\Microsoft.VisualStudio.Extensibility.Testing.Xunit.csproj]

We probably need to condition this test project out when building inside the VMR: DotNetBuildFromVMR=true

The other one is in runtime:

D:\a_work\1\s\src\runtime\eng\AcquireWasiSdk.targets(45,5): error MSB3073: The command "powershell -NonInteractive -command "& D:\a_work\1\s\src\runtime\eng\download-wasi-sdk.ps1 -WasiSdkUrl https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-25/wasi-sdk-25.0-x86_64-windows.tar.gz -WasiSdkVersion 25.0 -WasiSdkPath D:\a_work\1\s\src\runtime\artifacts\wasi-sdk; Exit $LastExitCode "" exited with code 52. [D:\a_work\1\s\src\runtime\src\mono\mono.proj]

Is that the powershell policy change thing that people mentioned in chat?

@jjonescz
Copy link
Member

jjonescz commented Dec 19, 2025

We probably need to condition this test project out when building inside the VMR: DotNetBuildFromVMR=true

That needs cherry pick of the last commit from #3921

@ViktorHofer ViktorHofer enabled auto-merge (squash) December 19, 2025 10:42
@jjonescz
Copy link
Member

jjonescz commented Dec 19, 2025 •
edited
Loading

src/templating/src/Microsoft.TemplateEngine.Utils/DictionaryExtensions.cs(88,34): error IDE0370: Suppression is unnecessary (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0370)

@dotnet/roslyn-ide / @dotnet/roslyn-infrastructure do you know why this diagnostic starts appearing all of a sudden, was there some fix?

I'm also not sure why it doesn't appear in the release/10.0.2xx branch. Maybe it's some .NET 10 vs 11 difference (something with analysis level)...?

@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 19, 2025

/__w/1/s/.dotnet/sdk/10.0.100/NuGet.Build.Tasks.Pack.targets(222,5): error : The process cannot access the file '/__w/1/s/src/roslyn/artifacts/packages/Release/Shipping/Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator.5.3.0-ci.nupkg' because it is being used by another process. [/__w/1/s/src/roslyn/src/VisualStudio/IntegrationTest/Harness/SourceGenerator/Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator.csproj]

Looks like you have a race in roslyn that you might want to look into. Will probably go away after a retry.

@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 19, 2025 12:39
@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 19, 2025 •
edited
Loading

@jjonescz looks like this is from dotnet/roslyn#80794 and this is failing in the SB stage2 leg which uses the just built compiler as the toolset.

jjonescz
jjonescz reviewed Dec 19, 2025
View reviewed changes
@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 19, 2025 12:47
@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 19, 2025

@jjonescz you are right, my fixes don't work in multi-targeting projects due to different public API annotations in the BCL. Would you mind taking this one over? Feel free to revert my commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjonescz jjonescz jjonescz left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @jjonescz @dibarbet