Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 9, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

…208.6

On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Analyzers From Version 3.11.0 -> To Version 5.3.0-2.25608.6
Microsoft.CodeAnalysis.AnalyzerUtilities From Version 3.3.0 -> To Version 5.3.0-2.25608.6
Microsoft.Net.Compilers.Toolset From Version 4.10.0-1.24061.4 -> To Version 5.3.0-2.25608.6
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner December 9, 2025 13:19
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

Copy link
Member

@jjonescz jjonescz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking to avoid auto merge

<ProductDependencies>
<!-- RoslynAnalyzers reference older builds of Roslyn and this is necessary for SourceBuild. -->
<Dependency Name="Microsoft.CodeAnalysis" Version="3.11.0">
<Dependency Name="Microsoft.CodeAnalysis" Version="5.3.0-2.25608.6">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is fine. @JoeRobich?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine. RoslynAnalyzers uses a separate version property that is disconnected from MicrosoftCodeAnalysisPackageVersion. In fact it is using 4.12.0 which is different from this already.

@jjonescz jjonescz dismissed their stale review December 9, 2025 18:45

Looks good

@dibarbet dibarbet enabled auto-merge (squash) December 9, 2025 22:31
@dibarbet dibarbet merged commit 9143e6e into main Dec 9, 2025
28 of 29 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 9, 2025
@dotnet-maestro dotnet-maestro bot deleted the darc-main-933deed4-c6da-4c40-be1f-acf247e8ce44 branch December 9, 2025 23:18
333fred added a commit to 333fred/roslyn that referenced this pull request Dec 9, 2025
* upstream/main: (221 commits)
  [main] Update dependencies from dotnet/roslyn (dotnet#81601)
  Update Roslyn.Diagnostics.Analyzers (dotnet#81599)
  Remove unnecessary lightup code
  Remove unnecessary lightup code
  Remove unnecessary lightup code
  Remove unnecessary lightup code
  Remove unnecessary lightup code
  Build
  NullableWalker.DebugVerifier: Explicitly visit `BoundCollectionExpressionSpreadElement.Conversion` (dotnet#81584)
  SyntheticBoundNodeFactory: Remove ability to create arbitrary conversions  (dotnet#81569)
  Docs
  Tweak
  Remove dependency on Newtonsoft.Json from Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost (dotnet#81562)
  Simplify
  Apply suggestions from code review
  Make into theory
  Updates
  Add tests
  Add tests
  Improve go-to-def navigation in overload resolution failure cases
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants