-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[main] Update dependencies from dotnet/roslyn #81601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…208.6 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Analyzers From Version 3.11.0 -> To Version 5.3.0-2.25608.6 Microsoft.CodeAnalysis.AnalyzerUtilities From Version 3.3.0 -> To Version 5.3.0-2.25608.6 Microsoft.Net.Compilers.Toolset From Version 4.10.0-1.24061.4 -> To Version 5.3.0-2.25608.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approve
jjonescz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking to avoid auto merge
| <ProductDependencies> | ||
| <!-- RoslynAnalyzers reference older builds of Roslyn and this is necessary for SourceBuild. --> | ||
| <Dependency Name="Microsoft.CodeAnalysis" Version="3.11.0"> | ||
| <Dependency Name="Microsoft.CodeAnalysis" Version="5.3.0-2.25608.6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is fine. @JoeRobich?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine. RoslynAnalyzers uses a separate version property that is disconnected from MicrosoftCodeAnalysisPackageVersion. In fact it is using 4.12.0 which is different from this already.
* upstream/main: (221 commits) [main] Update dependencies from dotnet/roslyn (dotnet#81601) Update Roslyn.Diagnostics.Analyzers (dotnet#81599) Remove unnecessary lightup code Remove unnecessary lightup code Remove unnecessary lightup code Remove unnecessary lightup code Remove unnecessary lightup code Build NullableWalker.DebugVerifier: Explicitly visit `BoundCollectionExpressionSpreadElement.Conversion` (dotnet#81584) SyntheticBoundNodeFactory: Remove ability to create arbitrary conversions (dotnet#81569) Docs Tweak Remove dependency on Newtonsoft.Json from Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost (dotnet#81562) Simplify Apply suggestions from code review Make into theory Updates Add tests Add tests Improve go-to-def navigation in overload resolution failure cases ...
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn