Generate docs - fix an issue where the suggestion session was being overtaken#81537
Merged
akhera99 merged 5 commits intodotnet:mainfrom Dec 5, 2025
Merged
Generate docs - fix an issue where the suggestion session was being overtaken#81537akhera99 merged 5 commits intodotnet:mainfrom
akhera99 merged 5 commits intodotnet:mainfrom
Conversation
JoeRobich
reviewed
Dec 4, 2025
JoeRobich
reviewed
Dec 4, 2025
src/EditorFeatures/Core/DocumentationComments/AbstractDocumentationCommentCommandHandler.cs
Outdated
Show resolved
Hide resolved
JoeRobich
approved these changes
Dec 4, 2025
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that generate documentation was only intermittently starting a Suggestion Session.
This was tracked down to inline completions taking control of the Suggestion Session since it creates the session before making calls into the LLM, while our generate documentation was waiting until after.
The fix:
Had to create the Suggestion Session early and prior to calling
nextHandler()so that we keep control. This also means we have to check earlier whether or not the trigger character is at the last slash to insert the doc comment.