Remove smart rename lightup #81598
Remove smart rename lightup #81598
Conversation
| context | ||
| .Select(n => new KeyValuePair<string, ImmutableArray<(string filePath, string content)>>(n.Key, n.Value))); | ||
| smartRenameContext = ImmutableDictionary.CreateRange( | ||
| context.Select(n => KeyValuePair.Create(n.Key, n.Value.SelectMany(t => new[] { t.filePath, t.content }).ToArray()))); |
There was a problem hiding this comment.
i didn't k now what to do here. It seems like the old code was just outright buggy. there is no way this was operating without throwing exceptions afaict.
There was a problem hiding this comment.
i made it at least compile. but i have no idea what the expectation is here mapping from our ImmutableDictionary<string, ImmutableArray<(string filePath, string content)>> to their ImmutableDictionary<string, string[]>. @akhera99 can you specify what should happen here?
There was a problem hiding this comment.
There are two public methods, one taking ImmutableDictionary<string, string[]> and another ImmutableArray<RenameContext> as the first parameter. source link
There was a problem hiding this comment.
thanks, i moved to the latter.
| context.Select(n => KeyValuePair.Create(n.Key, n.Value.SelectMany(t => new[] { t.filePath, t.content }).ToArray()))); | ||
| _semanticContextDelay = stopwatch.Elapsed; | ||
| } | ||
| catch (Exception e) when (FatalError.ReportAndCatch(e, ErrorSeverity.Diagnostic)) |
There was a problem hiding this comment.
I think this code existed to just always catch/mask that this was always failing. i would like to remove the try/catch, but this entire model scares me a bit.
There was a problem hiding this comment.
does it no longer catch anything after your fix?
|
@Cosifne ptal. |
AmadeusW
left a comment
There was a problem hiding this comment.
Overall looks good, I left couple comments.
Cosifne
left a comment
There was a problem hiding this comment.
I guess you still need to get someone else's approval because I am no longer in the team
No description provided.