Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DeclarationTable allocation reductions #81627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ToddGrun merged 6 commits into from
Dec 17, 2025
Merged

DeclarationTable allocation reductions #81627

ToddGrun merged 6 commits into from
Dec 17, 2025
+412 −118

Conversation

@ToddGrun
Copy link
Contributor

@ToddGrun ToddGrun commented Dec 10, 2025 •
edited
Loading

Make and use a builder for DeclarationTable edits to reduce allocations from creating intermediary DeclarationTable and repeated modifications to an underlying ImmutableDictionary.

Insertion PR: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/695154

PIT results:
image

Allocations in VS under SyntaxAndDeclarationManager.CreateState from ScrollingAndTyping test, Typing scenario:

*** Before ***
image

*** After ***
image

@ToddGrun
*** WIP
191610b 
Will cleanup and add more details if speedometer run looks promising.

Create builder for DeclarationTable to reduce allocations.
@build-analysis build-analysis bot mentioned this pull request Dec 10, 2025
Open
3 tasks
@ToddGrun ToddGrun changed the title *** WIP -- DeclarationTable allocation reductions DeclarationTable allocation reductions Dec 13, 2025
@ToddGrun ToddGrun marked this pull request as ready for review December 13, 2025 15:03
@ToddGrun ToddGrun requested a review from a team as a code owner December 13, 2025 15:03
@ToddGrun
Copy link
Contributor Author

ToddGrun commented Dec 13, 2025

Finally got perf results back, and this looked promising. Elevating out of draft status and this is ready for review.

@ToddGrun
Copy link
Contributor Author

ToddGrun commented Dec 16, 2025

@dotnet/roslyn-compiler -- ptal

AlekseyTs
AlekseyTs approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 5)

@AlekseyTs AlekseyTs requested a review from a team December 16, 2025 19:09
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Dec 16, 2025

@dotnet/roslyn-compiler For a second review

CyrusNajmabadi
CyrusNajmabadi reviewed Dec 16, 2025
View reviewed changes
@ToddGrun ToddGrun merged commit 383a15a into dotnet:main Dec 17, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 17, 2025
This was referenced Dec 18, 2025
Merged
Merged
@dotnet-bot dotnet-bot mentioned this pull request Dec 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

No one assigned

Labels

Area-Compilers

Projects

None yet

Milestone

Next

Development

Successfully merging this pull request may close these issues.

3 participants

@ToddGrun @AlekseyTs @CyrusNajmabadi