Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove obsolete IsBitness64 check from DeleteControl test #81137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jasonmalinowski merged 2 commits into from
Nov 10, 2025
Merged

Remove obsolete IsBitness64 check from DeleteControl test #81137

jasonmalinowski merged 2 commits into from
Nov 10, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025 •
edited
Loading

All tests now run on 64-bit systems, making the bitness check unnecessary.

Changes:

  • Removed if (ExecutionConditionUtil.IsBitness64) wrapper from DeleteControl test method
  • Test body now executes unconditionally
[IdeFact]
public async Task DeleteControl()
{
-   if (ExecutionConditionUtil.IsBitness64)
-   {
        var project = ProjectName;
        await TestServices.SolutionExplorer.OpenFileWithDesignerAsync(project, "Form1.cs", ...);
        // ... rest of test
-   }
}
Original prompt

On CSharpWinForms.cs:217-217, Please delete this check of IsBitness64; it doesn't need to exist since all tests at this point are running on 64-bit. No comment is needed.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove unnecessary IsBitness64 check from CSharpWinForms Remove obsolete IsBitness64 check from DeleteControl test Nov 10, 2025
@jasonmalinowski jasonmalinowski marked this pull request as ready for review November 10, 2025 19:41
@jasonmalinowski jasonmalinowski requested a review from a team as a code owner November 10, 2025 19:41
@jasonmalinowski jasonmalinowski merged commit 8419937 into main Nov 10, 2025
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 10, 2025
@dotnet-bot dotnet-bot mentioned this pull request Nov 12, 2025
Closed
@CyrusNajmabadi CyrusNajmabadi deleted the copilot/remove-isbitness64-check branch December 2, 2025 11:52
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jasonmalinowski jasonmalinowski

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

Next

Development

Successfully merging this pull request may close these issues.

3 participants

@jasonmalinowski @CyrusNajmabadi