Report basic text changes if span mapping isn't available #81492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@CyrusNajmabadi quid pro quo? |
akhera99
reviewed
Dec 1, 2025
src/LanguageServer/ProtocolUnitTests/TestSourceGeneratedDocumentSpanMappingService.cs
Outdated
Show resolved
Hide resolved
akhera99
approved these changes
Dec 1, 2025
This was referenced Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stuffed up, in #81450 I map LSP rename map edits so that Razor components could be renamed, but this actually broke Razor rename in VS, because it runs in OOP, and the Razor mapping service is not part of the composition. The fix is easy - Razor will do the mapping when it gets the results - just need to make Roslyn actually give the edits back to Razor so it can.
Diff best viewed with whitespace off.