EnC: Block additions to MethodImpl table when targeting .NET Framework #81304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@DustinCampbell @dotnet/roslyn-compiler ptal |
Member
|
Build failures look real. |
333fred
approved these changes
Nov 18, 2025
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM, assuming CI is passing.
AlekseyTs
reviewed
Nov 20, 2025
AlekseyTs
reviewed
Nov 20, 2025
| ERRID.ERR_CannotApplyOverloadResolutionPriorityToOverride, | ||
| ERRID.ERR_CannotApplyOverloadResolutionPriorityToMember, | ||
| ERRID.ERR_NextAvailable, | ||
| ERRID.ERR_EncUpdateRequiresEmittingExplicitInterfaceImplementationNotSupportedByTheRuntime, |
Contributor
AlekseyTs
reviewed
Nov 20, 2025
src/Features/Core/Portable/EditAndContinue/EditAndContinueCapabilities.cs
Show resolved
Hide resolved
Contributor
|
Done with review pass (commit 4) |
DustinCampbell
approved these changes
Nov 24, 2025
Contributor
|
Done with review pass (commit 5). It looks like there are merge conflicts that must be resolved. |
71cc1f2 to
69d87a2
Compare
Member
Author
|
@AlekseyTs Conflicts resolved. |
2d0c2f6 to
ef8531e
Compare
This was referenced Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block additions to MethodImpl table when targeting .NET Framework.
The EnC impl in .NET Framework doesn't handle them correctly.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2631743 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1452066/
Public API change: #81305