[menu-bar][macos] Extract Popover logic to a new class#263
Merged
gabrieldonadel merged 2 commits intomainfrom May 20, 2025
Merged
[menu-bar][macos] Extract Popover logic to a new class#263gabrieldonadel merged 2 commits intomainfrom
gabrieldonadel merged 2 commits intomainfrom
Conversation
c3d5a4c to
9a3aab9
Compare
alanjhughes
approved these changes
May 20, 2025
9a3aab9 to
838107e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We should simplify our AppDelegate logic in order to align it more with Expo's template
How
Extract the Popover and NSStatusBar item logic into a new class called
PopoverManagerTest Plan
Run macos menu bar locally