Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MeraX
Copy link
Contributor

@MeraX MeraX commented Nov 4, 2025

Description

Adds support for eccodes type formats in the rename filter

What problem does this change solve?

It was not possible to rename a variable e.g. with level:d.

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@github-project-automation github-project-automation bot moved this to To be triaged in Anemoi-dev Nov 4, 2025
@github-actions github-actions bot added tests enhancement New feature or request labels Nov 4, 2025
Copy link
Contributor

@aaron-hopkinson aaron-hopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks like it does what it's aiming to do, but the regular expression manipulation does make me feel a little uneasy that this could be a bit fragile in the future.

I've added couple of questions (mainly to aid my own understanding).

@MeraX MeraX force-pushed the feat/rename_format branch from 66a5a73 to 407a3d8 Compare November 4, 2025 16:35
Copy link
Contributor

@aaron-hopkinson aaron-hopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner. Thanks @MeraX!

@aaron-hopkinson aaron-hopkinson merged commit 00e9890 into main Nov 5, 2025
68 checks passed
@aaron-hopkinson aaron-hopkinson deleted the feat/rename_format branch November 5, 2025 14:28
@github-project-automation github-project-automation bot moved this from To be triaged to Done in Anemoi-dev Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants