feat: Support formats in rename filter #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Contributor
aaron-hopkinson
left a comment
There was a problem hiding this comment.
The code looks like it does what it's aiming to do, but the regular expression manipulation does make me feel a little uneasy that this could be a bit fragile in the future.
I've added couple of questions (mainly to aid my own understanding).
66a5a73 to
407a3d8
Compare
aaron-hopkinson
approved these changes
Nov 5, 2025
Contributor
aaron-hopkinson
left a comment
There was a problem hiding this comment.
Much cleaner. Thanks @MeraX!
anaprietonem
pushed a commit
that referenced
this pull request
Nov 11, 2025
🤖 Automated Release PR This PR was created by `release-please` to prepare the next release. Once merged: 1. A new version tag will be created 2. A GitHub release will be published 3. The changelog will be updated Changes to be included in the next release: --- ## [0.1.19](0.1.18...0.1.19) (2025-11-07) ### Features * Support formats in rename filter ([#186](#186)) ([00e9890](00e9890)) ### Bug Fixes * Update README to reflect project maturity status ([#184](#184)) ([d183f94](d183f94)) --- > [!IMPORTANT] > Please do not change the PR title, manifest file, or any other automatically generated content in this PR unless you understand the implications. Changes here can break the release process. >⚠️ Merging this PR will: > - Create a new release > - Trigger deployment pipelines > - Update package versions **Before merging:** - Ensure all tests pass - Review the changelog carefully - Get required approvals [Release-please documentation](https://github.com/googleapis/release-please)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for eccodes type formats in the rename filter
What problem does this change solve?
It was not possible to rename a variable e.g. with
level:d.As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.