feat(compute/init): allow --from to take a service ID #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Apr 29, 2024
phamann
reviewed
Apr 29, 2024
15ca3ae to
b8c2b8d
Compare
Integralist
reviewed
Apr 30, 2024
jsocol
commented
Apr 30, 2024
jsocol
commented
Apr 30, 2024
Member
Author
|
@Integralist I'm pretty sure I've caught all the unused bits and addressed all the feedback, mind taking another look? |
Integralist
approved these changes
May 1, 2024
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
LGTM. Going to approve for now, but would be nice to find a better package for IsFastlyID. I agree compute isn't the right place but I don't think argparser is either. Might have to be some other package like https://github.com/fastly/cli/blob/main/pkg/text/service.go (in my head I'm thinking text is about handling text input/output and so could make sense to be here)
The '--from' argument to 'fastly compute init' now accepts a Fastly Service ID, which must refer to an existing compute service with an uploaded binary package. The fastly.toml manifest will be populated with details from this existing service.
59ba316 to
71f5b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The '--from' argument to 'fastly compute init' now accepts a Fastly
Service ID, which must refer to an existing compute service. The
fastly.toml manifest will be populated with details from this existing
service.