Pass a cert-file argument instead of full cert blob. #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Apr 29, 2024
Member
cee-dub
reviewed
Apr 30, 2024
Collaborator
|
As mentioned by @jsocol earlier the failing CI https://github.com/fastly/cli/actions/runs/8881360752/job/24383545720?pr=1189 is because of a change that rolled out in the GitHub runners which resulted in a change in macos-latest architecture. So rebasing |
Contributor
Author
|
Thanks @jsocol and @Integralist for the tips! Will be a few days before I have time to work on this again. |
3afdf25 to
370feba
Compare
Integralist
reviewed
May 7, 2024
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
Looking good. Some comments to be addresses + the CI is failing to run the tests successfully (looks to be failing on TestTLSCustomCertCreate/validate_custom_cert_is_submitted)
9b704f3 to
582dbf9
Compare
Integralist
reviewed
May 14, 2024
Integralist
reviewed
May 14, 2024
Integralist
approved these changes
May 14, 2024
…to pass in a path to a certificate file Previously users were required to pass in the full certificate contents via the --cert-blob argument, which is cumbersome and error-prone. This allows users to specify a path to a certificate making this command easier to use. The new argument --cert-path is mutually exclusive with --cert-blob and the command will return an error if both are specified.
a8efcbb to
58f82af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --cert-path argument to tls-custom certificate create command to pass in a path to a certificate file
Previously users were required to pass in the full certificate contents via the --cert-blob argument, which is cumbersome and error-prone. This allows users to specify a path to a certificate making this command easier to use.
The new argument --cert-path is mutually exclusive with --cert-blob and the command will return an error if both are specified.