Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Oct 23, 2025

Change summary

This fixes #1329.
This PR correctly maps the required fields for creating a TLS Activation. Previously we were inputting a unclear id field and not intaking the required tls_domain api field. The input flags have been updated to require the following flags instead:

  --cert-id=CERT-ID                         Alphanumeric string identifying a TLS certificate
  --tls-config-id=TLS-CONFIG-ID  Alphanumeric string identifying a TLS configuration
  --tls-domain=TLS-DOMAIN        The domain name associated with the TLS activation

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

Users may now use the CLI for creating new TLS activations.

Are there any considerations that need to be addressed for release?

This is a breaking change as we are modifying command parameters.

@rcaril rcaril requested a review from a team as a code owner October 23, 2025 15:52
@rcaril rcaril requested a review from philippschulte October 23, 2025 15:52
@philippschulte philippschulte changed the title fix(tls-custom): Correct 'tls-custom activation enable' command parameters to reflect expected input from API Correct 'tls-custom activation enable' command parameters to reflect expected input from API Oct 23, 2025
@rcaril rcaril changed the title Correct 'tls-custom activation enable' command parameters to reflect expected input from API fix(tls-custom): Correct 'tls-custom activation enable' command parameters to reflect expected input from API Oct 23, 2025
@philippschulte philippschulte changed the title fix(tls-custom): Correct 'tls-custom activation enable' command parameters to reflect expected input from API [CDTOOL-1195] Correct 'tls-custom activation enable' command parameters to reflect expected input from API Oct 23, 2025
@rcaril rcaril changed the title [CDTOOL-1195] Correct 'tls-custom activation enable' command parameters to reflect expected input from API fix(tls-custom): Correct 'tls-custom activation enable' command parameters to reflect expected input from API Oct 23, 2025
@rcaril rcaril changed the title fix(tls-custom): Correct 'tls-custom activation enable' command parameters to reflect expected input from API [CDTOOL-1195] - Correct 'tls-custom activation enable' command parameters to reflect expected input from API Oct 23, 2025
@philippschulte philippschulte changed the title [CDTOOL-1195] - Correct 'tls-custom activation enable' command parameters to reflect expected input from API [CDTOOL-1195] Correct 'tls-custom activation enable' command parameters to reflect expected input from API Oct 23, 2025
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look solid! This introduces a breaking change and needs to be moved in the proper section of the CHANGELOG. Thank you!

@rcaril rcaril merged commit 753bfb8 into main Oct 23, 2025
26 of 29 checks passed
@rcaril rcaril deleted the CDTOOL-1195 branch October 23, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom certificate activation failure

3 participants