[CDTOOL-1195] Correct 'tls-custom activation enable' command parameters to reflect expected input from API#1562
Merged
[CDTOOL-1195] Correct 'tls-custom activation enable' command parameters to reflect expected input from API#1562
Conversation
philippschulte
approved these changes
Oct 23, 2025
Member
philippschulte
left a comment
There was a problem hiding this comment.
The code changes look solid! This introduces a breaking change and needs to be moved in the proper section of the CHANGELOG. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
This fixes #1329.
This PR correctly maps the required fields for creating a TLS Activation. Previously we were inputting a unclear
idfield and not intaking the requiredtls_domainapi field. The input flags have been updated to require the following flags instead:All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Users may now use the CLI for creating new TLS activations.
Are there any considerations that need to be addressed for release?
This is a breaking change as we are modifying command parameters.