Create setters/getters for check modes and fix management#294
Merged
TomDonoghue merged 8 commits intofooof-tools:checkmodesfrom Jul 23, 2023
Merged
Create setters/getters for check modes and fix management#294TomDonoghue merged 8 commits intofooof-tools:checkmodesfrom
TomDonoghue merged 8 commits intofooof-tools:checkmodesfrom
Conversation
…roup() and get_fooof()
Member
|
Awesome, thanks @SM-Figueroa! I redirected this PR to #293 and did a merge commit to combine the additions here with those (you can see the changes in the last commit). I'm going to merge this PR now, which will add your changes to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adds setters and getters for run_modes in fooof objects in fit.py. The dictionary returned by get_description() in info.py includes attributes for all run_modes. The get_fooof() and get_group() functions in group.py are now updated to probably transfer run mode settings from the current object to newly instantiated objects. Documentation relating to run_modes was updated in all files.
This Pull Request relates to this issue.