[MNT] - Fix management of check modes#293
Merged
TomDonoghue merged 17 commits intomainfrom Jul 25, 2023
Merged
Conversation
…roup() and get_fooof()
Closed
Create setters/getters for check modes and fix management
Contributor
ryanhammonds
left a comment
There was a problem hiding this comment.
Looks good! I left a couple optional/minor comments
[MNT] - Update parameter Stepper object
Member
Author
|
I'm going to merge this in now, to consolidate 1.1 to main and merge that forward to 2.0 - but if anyone has any further comments on this feel free to comment and we can follow up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #292 - updates process for managing check modes, and updates extracting of sub-objects to propagate modes
This also integrates updates from @SM-Figueroa, merged in #294, which updated some element of run mode management, including adding the
set_run_modesmethod. I also updated something that @SM-Figueroa explored but didn't add directly, which is using theFOOOFRunModesobject (it didn't initially work due to NamedTuples not accepting leading underscores, but the object itself doesn't need the underscores, it can be used without them, which is how I added it.@mwprestonjr - for wtv reason I can't seem to tag you in for a proper review - but does this look good for addressing what you brought up in #292