feat: Allow ceil & floor functions in salary slip formulae #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2023
(cherry picked from commit 1ff710d)
ruchamahabal
added a commit
that referenced
this pull request
May 30, 2023
…527) (#558) Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 31, 2023
# [14.4.0](v14.3.4...v14.4.0) (2023-05-31) ### Bug Fixes * check if shift is outside assignment period ([1ef0954](1ef0954)) * consider `curr_shift` to retrieve `prev_shift` when possible ([a4889b0](a4889b0)) * make promotion details table non-mandatory (backport [#559](#559)) ([#560](#560)) ([751adf4](751adf4)) * midnight shift not fetched in checkin if assignment is missing on shift's end date ([ab4f980](ab4f980)) * rectify time overlap validation for midnight shifts ([21e71e8](21e71e8)) * remove rounding default for earned leave (backport [#547](#547)) ([#549](#549)) ([8da0656](8da0656)) * set default to zero on salary component. ([#552](#552)) ([d846d84](d846d84)) ### Features * Allow ceil & floor functions in salary slip formulae (backport [#527](#527)) ([#558](#558)) ([f8bb10c](f8bb10c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components like ESIC don't follow traditional rounding. They need to be rounded up to the next higher rupee.
1.2 -> 2
1.5 -> 2
Allow ceil & floor functions in salary slip
whitelisted_globalsso that it can be used in formulaeEg:
Component:
Salary Slip:
Docs: https://frappehr.com/docs/v14/user/manual/en/human-resources/salary-component