Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented May 30, 2023

This is an automatic backport of pull request #527 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.90%. Comparing base (be10055) to head (68c64d1).
⚠️ Report is 811 commits behind head on version-14-hotfix.

Files with missing lines Patch % Lines
hrms/payroll/doctype/salary_slip/salary_slip.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-14-hotfix     #558      +/-   ##
=====================================================
- Coverage              72.90%   72.90%   -0.01%     
=====================================================
  Files                    190      190              
  Lines                   9872     9871       -1     
=====================================================
- Hits                    7197     7196       -1     
  Misses                  2675     2675              
Files with missing lines Coverage Δ
hrms/payroll/doctype/salary_slip/salary_slip.py 86.95% <50.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruchamahabal ruchamahabal merged commit f8bb10c into version-14-hotfix May 30, 2023
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-527 branch May 30, 2023 10:35
frappe-pr-bot pushed a commit that referenced this pull request May 31, 2023
# [14.4.0](v14.3.4...v14.4.0) (2023-05-31)

### Bug Fixes

* check if shift is outside assignment period ([1ef0954](1ef0954))
* consider `curr_shift` to retrieve `prev_shift` when possible ([a4889b0](a4889b0))
* make promotion details table non-mandatory (backport [#559](#559)) ([#560](#560)) ([751adf4](751adf4))
* midnight shift not fetched in checkin if assignment is missing on shift's end date ([ab4f980](ab4f980))
* rectify time overlap validation for midnight shifts ([21e71e8](21e71e8))
* remove rounding default for earned leave (backport [#547](#547)) ([#549](#549)) ([8da0656](8da0656))
* set default to zero on salary component. ([#552](#552)) ([d846d84](d846d84))

### Features

* Allow ceil & floor functions in salary slip formulae (backport [#527](#527)) ([#558](#558)) ([f8bb10c](f8bb10c))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants