source/dcell/termio.d (2)

14-14: Remove the redundant local import on line 232.

The top-level import of std.algorithm makes the local selective import on line 232 (import std.algorithm : max;) redundant.

Apply this diff to remove the redundant import:

        import std.algorithm : max;

-        int num = select(max(fd, sigRfd) + 1, &readFds, null, null, tvp);
+        int num = select(max(fd, sigRfd) + 1, &readFds, null, null, tvp);

Actually, simply remove line 232:

-        import std.algorithm : max;
-
         int num = select(max(fd, sigRfd) + 1, &readFds, null, null, tvp);

---

283-285: Consider adding minimum duration clamping for consistency.

The 24-hour maximum clamp prevents overflow (86,400,000 ms fits well within int range). However, unlike the UseSelect path which clamps to a minimum of 10µs, this path doesn't enforce a minimum. A negative or zero non-max duration will result in dly = 0, which is valid but inconsistent with the select path's behavior.

Consider applying this diff for consistency:

         else
         {
-            // clip to a day to prevent overrun
-            dur = min(hours(24), dur);
+            // clip between 10us and a day to prevent overrun
+            dur = min(hours(24), max(dur, usecs(10)));
             dly = cast(int)(dur.total!"msecs");
         }

This ensures both paths treat zero/negative durations consistently.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro