Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: hang on macOS due to overflow/underflow of durations #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdamore merged 1 commit into from
Dec 15, 2025
Merged

fix: hang on macOS due to overflow/underflow of durations #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions source/dcell/termio.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
*/
module dcell.termio;

import std.algorithm;
import std.datetime;
import std.exception;
import std.range.interfaces;
Expand Down Expand Up @@ -212,16 +213,19 @@ class PosixTty : Tty
FD_SET(fd, &readFds);
FD_SET(sigRfd, &readFds);

if (dur == Duration.max || dur.isNegative)
if (dur == Duration.max)
{
tvp = null;
}
else
{
// at least 10us, not more than an hour.
dur = min(hours(1), max(dur, usecs(10)));
auto usecs = dur.total!"usecs";
assert(usecs > 0);

timeout.tv_sec = cast(typeof(timeout.tv_sec)) usecs / 1_000_000;
timeout.tv_usec = cast(typeof(timeout.tv_usec)) usecs % 1_000_000;
timeout.tv_sec = cast(typeof(timeout.tv_sec))(usecs / 1_000_000);
timeout.tv_usec = cast(typeof(timeout.tv_usec))(usecs % 1_000_000);
tvp = &timeout;
}

Expand Down Expand Up @@ -276,6 +280,8 @@ class PosixTty : Tty
}
else
{
// clip to a day to prevent overrun
dur = min(hours(24), dur);
dly = cast(int)(dur.total!"msecs");
}

Expand Down