Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@b-butler
Copy link
Member

Description

Release minor version of signac.

@b-butler b-butler requested review from a team as code owners September 19, 2022 19:03
@b-butler b-butler requested review from Charlottez112 and vyasr and removed request for a team September 19, 2022 19:03
@bdice
Copy link
Member

bdice commented Sep 19, 2022

I'd like to get a review/merge some form of this PR before releasing 1.8.0: #818

@bdice bdice added this to the v1.8.0 milestone Sep 19, 2022
@bdice
Copy link
Member

bdice commented Sep 20, 2022

@b-butler Can you help me understand what all the refactoring commits are doing? Are there warnings that you're trying to suppress? Are there tasks we missed that should be reviewed and merged into master as separate PRs? (Typically "release" PRs are trivial and only involve version bumps.)

@bdice bdice mentioned this pull request Sep 21, 2022
6 tasks
@bdice
Copy link
Member

bdice commented Sep 21, 2022

I worked through the deprecations with @b-butler and @mikemhenry on #820 in real time.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #819 (52a365d) into master (c9a48fc) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   78.46%   78.42%   -0.05%     
==========================================
  Files          64       64              
  Lines        7230     7230              
  Branches     1465     1465              
==========================================
- Hits         5673     5670       -3     
  Misses       1244     1244              
- Partials      313      316       +3     
Impacted Files Coverage Δ
signac/version.py 100.00% <100.00%> (ø)
signac/common/deprecation/__init__.py 61.11% <0.00%> (-3.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdice
Copy link
Member

bdice commented Sep 21, 2022

Before this is ready to release, we need a new GitHub Action to deploy to the test PyPI server (and the real PyPI when we merge/tag).

@vyasr
Copy link
Contributor

vyasr commented Sep 25, 2022

Before this is ready to release, we need a new GitHub Action to deploy to the test PyPI server (and the real PyPI when we merge/tag).

@bdice @b-butler I handled this in #821.

@b-butler
Copy link
Member Author

b-butler commented Oct 5, 2022

The package now builds wheels and publishes to TestPyPI correctly, so I think it should be good to merge.

@bdice
Copy link
Member

bdice commented Oct 5, 2022

Agreed! This is ready to go. @b-butler You can merge and finalize the GitHub release.

@bdice bdice merged commit 6776c02 into master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants