Enable deployment via GH actions #821
Conversation
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 78.46% 78.46%
=======================================
Files 64 64
Lines 7230 7230
Branches 1465 1465
=======================================
Hits 5673 5673
Misses 1244 1244
Partials 313 313 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
If reviewers are interested you can look into the actions tab to see the last few runs of both the TestPyPI and normal PyPI upload workflows. Up until the last few commits I had it triggering on every push to the branch and disabled the final twine uploads, so you can see the rest of the output there. You can also see that in the two cases where I did enable TestPyPI uploads we did get new packages (dev0 and dev1 releases). I tested it reasonably thoroughly and feel pretty good with it, but we can of course do some final testing once that is merged by rebasing our 1.8 release branch after this PR is merged and making any final edits in that PR. |
|
@vyasr Thank you so much for working on this! |
csadorf
left a comment
There was a problem hiding this comment.
Thanks for taking this on! Two suggestions.
Changes the publish-packages action to use only one `pip install` command. Co-authored-by: Carl Simon Adorf <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Also separate building and publishing into separate jobs.
Description
This PR adds in Github Actions workflows to deploy packages to TestPyPI on release branches and to PyPI itself whenever a tag is pushed.
Motivation and Context
We need these in place for releases. When switching from CircleCI to Github Actions we chose not to port the deployment step, opting to instead wait until we had an actual release since we knew we would need to work through some issues. This PR handles those changes.
Checklist: