feat: provide API to load modules from npm registry #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b85da5e to
af1886f
Compare
af1886f to
4644298
Compare
|
Awesome! Looks super cool. But let’s try to simplify a little bit. I have a few ideas 💡 |
antonmedv
reviewed
Aug 25, 2022
antonmedv
reviewed
Aug 25, 2022
antonmedv
reviewed
Aug 25, 2022
| return {} | ||
| } | ||
|
|
||
| await $`npm install --no-save --no-audit --no-fund ${flags} ${pkgs}` |
antonmedv
reviewed
Aug 25, 2022
deps API to load modules from npm registry
antonmedv
reviewed
Aug 27, 2022
src/cli.ts
Outdated
| if (argv.install) { | ||
| await installDeps(parseDeps(contents), { | ||
| prefix: dirname(filepath), | ||
| registry: argv.registy, |
There was a problem hiding this comment.
can touse be passed via env args? To not pollute argv?
There was a problem hiding this comment.
ZX_REGISTRY / ZX_USERCONFIG?
or std npm_config_*?
antonmedv
approved these changes
Aug 27, 2022
8227814 to
9d6ca3a
Compare
9d6ca3a to
46aed65
Compare
|
I’m going to update dev branch, lets merge there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.