Dep: update node-fetch #507
Conversation
| { | ||
| "compilerOptions": { | ||
| "target": "ES2021", | ||
| "lib": ["ES2021"], |
There was a problem hiding this comment.
This is the reason, I don't what to update node-fetch to the newest version.
Probably gonna looks for some other implementation of fetch API.
There was a problem hiding this comment.
We could use Axios or wait for Node's core fetch implementation as alternatives. Happy to help if needed 😊
There was a problem hiding this comment.
@antongolub should we add dom? And make zx v8 with node's fetch?
|
@antongolub what are your thoughts? |
|
It's time to drop fetch polyfill, IMO. If it is still needed, it will be possible to use #498 to install |
|
So remove |
|
I'm going to close the PR. I'll keep an eye on issues and try help when/where I can :) |
Fixes #506
Minor fix for CVE-2022-2596
Also added a temp fix for a type issue brought in by the latest update in node-fetch.
See: node-fetch/node-fetch#1617
First contribution, so any suggestions or things I've missed are greatly welcomed.