Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: provide formatters shortcuts #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonmedv merged 9 commits into from
May 19, 2024
Merged

feat: provide formatters shortcuts #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ebf8048
feat request: provide formatters shortcuts #764
Anonymous961 May 16, 2024
6d5f3b1
Revert "feat request: provide formatters shortcuts #764"
Anonymous961 May 17, 2024
cd963e0
feat: provide formatters shortcuts
Anonymous961 May 17, 2024
9e0c5f3
fix: correct formatting
Anonymous961 May 17, 2024
a242994
Merge branch 'main' into main
Anonymous961 May 17, 2024
1f5df81
fix: simplified json test
Anonymous961 May 17, 2024
39bfdf5
Merge branch 'google:main' into main
Anonymous961 May 17, 2024
6b96a47
Merge branch 'main' of https://github.com/google/zx
Anonymous961 May 17, 2024
14a27a7
Merge remote-tracking branch 'fork/main'
Anonymous961 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,18 @@ export class ProcessOutput extends Error {
return this._combined
}

json() {
return JSON.parse(this._combined)
}

buffer() {
return Buffer.from(this._combined, 'utf8')
}

text() {
return this._combined
}

valueOf() {
return this._combined.trim()
}
Expand Down
15 changes: 15 additions & 0 deletions test/core.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,21 @@ describe('core', () => {
assert.equal((await p).toString(), 'foo\n')
})

test('ProcessPromise: implements json()', async () => {
Copy link
Collaborator

@antongolub antongolub May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ProcessPromise here but ProcessOutput.

Copy link
Contributor Author

@Anonymous961 Anonymous961 May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for text() and buffer()? I just followed toString() test.

Copy link
Contributor Author

@Anonymous961 Anonymous961 May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antongolub should I also change ProcessOutput for toString() test?

const p = $`echo '{"key":"value"}'`
assert.deepEqual((await p).json(), { key: 'value' })
})

test('ProcessPromise: implements text()', async () => {
const p = $`echo foo`
assert.equal((await p).toString(), 'foo\n')
})

test('ProcessPromise: implements buffer()', async () => {
const p = $`echo foo`
assert.equal((await p).buffer().compare(Buffer.from('foo\n', 'utf-8')), 0)
})

test('ProcessPromise: implements valueOf()', async () => {
const p = $`echo foo`
assert.equal((await p).valueOf(), 'foo')
Expand Down