feat: provide formatters shortcuts #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anil Kumar Behera <[email protected]>
antongolub
reviewed
May 16, 2024
This reverts commit ebf8048.
chankruze
suggested changes
May 17, 2024
Signed-off-by: Anil Kumar Behera <[email protected]>
antongolub
requested changes
May 17, 2024
antongolub
requested changes
May 17, 2024
antongolub
reviewed
May 19, 2024
| assert.equal((await p).toString(), 'foo\n') | ||
| }) | ||
|
|
||
| test('ProcessPromise: implements json()', async () => { |
Collaborator
There was a problem hiding this comment.
Not ProcessPromise here but ProcessOutput.
Contributor
Author
There was a problem hiding this comment.
same for text() and buffer()? I just followed toString() test.
Contributor
Author
There was a problem hiding this comment.
@antongolub should I also change ProcessOutput for toString() test?
antongolub
approved these changes
May 19, 2024
Collaborator
antongolub
left a comment
There was a problem hiding this comment.
lgtm. we will land the rest part in another PR
antongolub
added a commit
to antongolub/zx
that referenced
this pull request
May 20, 2024
continues google#811 relates google#764
1 task
antonmedv
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #764
json(),'text(),bufffer().json(),'text(),bufffer().Not sure about the stream function. Would like to have more context.