Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: provide format methods for ProcessPromise #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonmedv merged 1 commit into from
May 21, 2024
Merged

feat: provide format methods for ProcessPromise #815

antonmedv merged 1 commit into from
May 21, 2024

Conversation

@antongolub
Copy link
Collaborator

@antongolub antongolub commented May 20, 2024

continues #811
relates #764

const p = $`echo 'foo\nbar'`

await p.text()        // foo\n\bar\n
await p.text('hex')   //  666f6f0a0861720a
await p.buffer()      //  Buffer.from('foo\n\bar\n')
await p.lines()       // ['foo', 'bar']
await $`echo '{"foo": "bar"}'`.json() // {foo: 'bar'}
  • Tests pass

@antonmedv
Copy link
Collaborator

antonmedv commented May 21, 2024

Hmmm, im not sure we need those. Let’s keep API surface smaller?

antonmedv
antonmedv reviewed May 21, 2024
View reviewed changes
src/core.ts
: this.buffer().toString(encoding)
}

lines() {
Copy link
Collaborator

@antonmedv antonmedv May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just .text().split ()?

@antonmedv antonmedv merged commit 1f7ce4e into google:main May 21, 2024
@WeiLunSnyk WeiLunSnyk mentioned this pull request Jun 13, 2024
Merged
@WeiLunSnyk WeiLunSnyk mentioned this pull request Jun 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonmedv antonmedv antonmedv left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antongolub @antonmedv