Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Conversation

@michaelasp
Copy link
Collaborator

@michaelasp michaelasp commented Jul 22, 2025

Moves to using V1 apis and standard k8s functions for obtaining the PCIERoot of the network device.

Fixes: #171

cc @everpeace since he added the helper function, this PR is modeled off NVIDIA/k8s-dra-driver-gpu#429 since it does very similar work. Thanks!

@michaelasp michaelasp force-pushed the standardk8s branch 4 times, most recently from 6cf1b6d to 4a049b2 Compare July 22, 2025 18:37
@michaelasp michaelasp force-pushed the standardk8s branch 2 times, most recently from 5e30c0b to e479d60 Compare July 22, 2025 21:59
@michaelasp michaelasp requested a review from aojea July 22, 2025 22:33
Copy link
Collaborator

@aojea aojea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for 1.34 to be released and make the final change just for the GA API avoiding going through v1beta2

@aojea
Copy link
Collaborator

aojea commented Jul 24, 2025

@michaelasp kubernetes just merged the GA API, this will require a good effort to move examples tests and all these things so feel free to use this PR to perform this migration to GA kubernetes/kubernetes#132706

@everpeace
Copy link

everpeace commented Jul 24, 2025

@michaelasp my PR kubernetes/kubernetes#133164, bumping dependent api version from v1beta2 to v1 for pcieRoot device attribute helper, is now merged waiting for tide test passed.

@michaelasp
Copy link
Collaborator Author

michaelasp commented Jul 24, 2025

@michaelasp kubernetes just merged the GA API, this will require a good effort to move examples tests and all these things so feel free to use this PR to perform this migration to GA kubernetes/kubernetes#132706

Done! Bumped up all the required libraries and seems good, now will just wait for a full release and it should be good to go :)

Does it make sense to also use this PR to move all the examples? I can make this a more generic PR then that just moves the APIs to V1

@michaelasp michaelasp force-pushed the standardk8s branch 3 times, most recently from 83e156f to a32c480 Compare July 24, 2025 17:16
@michaelasp michaelasp requested a review from aojea July 24, 2025 21:01
@aojea
Copy link
Collaborator

aojea commented Jul 24, 2025

Does it make sense to also use this PR to move all the examples? I can make this a more generic PR then that just moves the APIs to V1

I think is a good idea and we can use this PR as the v1 branch that we merge once kube has the first rc candidate on Wednesday 6th August 2025 https://www.kubernetes.dev/resources/release/

@michaelasp
Copy link
Collaborator Author

Does it make sense to also use this PR to move all the examples? I can make this a more generic PR then that just moves the APIs to V1

I think is a good idea and we can use this PR as the v1 branch that we merge once kube has the first rc candidate on Wednesday 6th August 2025 https://www.kubernetes.dev/resources/release/

Sgtm, I wonder if we'll break the KIND tests until a node image is released since the APIs are still unreleased. Let me give it a shot.

@aojea
Copy link
Collaborator

aojea commented Jul 24, 2025

Sgtm, I wonder if we'll break the KIND tests until a node image is released since the APIs are still unreleased. Let me give it a shot.

good point, but kind can consume artifacts from upstream , see https://kind.sigs.k8s.io/docs/user/quick-start/#building-images so you can point to the url

@michaelasp michaelasp changed the title Use Standard K8s function for PCIERoot Move DraNet to V1 DRA APIs Jul 24, 2025
@michaelasp michaelasp force-pushed the standardk8s branch 3 times, most recently from af51abf to d540072 Compare July 25, 2025 17:33
@michaelasp
Copy link
Collaborator Author

Looks like this is fully working on V1 apis. I'll create a follow up to move the examples to V1 apis and merge this when 1.34 is released and can move the tests away from pulling a specific node image.

@BenTheElder
Copy link
Collaborator

[needs a rebase again, though maybe we want to wait for the rc0 anyhow ...]

@michaelasp
Copy link
Collaborator Author

[needs a rebase again, though maybe we want to wait for the rc0 anyhow ...]

Yeah at this point we tested and it worked, I think we can wait till the rc0 cut

@aojea aojea added this to the v1.0 milestone Jul 29, 2025
@aojea
Copy link
Collaborator

aojea commented Jul 31, 2025

rc0 is Wed 6th of August, @michaelasp can you add yourself a reminder to get this in with rc0 https://www.kubernetes.dev/resources/release/

@michaelasp
Copy link
Collaborator Author

rc0 is Wed 6th of August, @michaelasp can you add yourself a reminder to get this in with rc0 https://www.kubernetes.dev/resources/release/

Sure, want me to merge today after I fix rebase issues? I can then fix on the 6th to pin to the RC instead.

Copy link
Collaborator

@aojea aojea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kevin (NVIDIA) merged today so it makes sense to get alignment

@aojea aojea merged commit 41c4f01 into google:main Jul 31, 2025
6 checks passed
@aojea
Copy link
Collaborator

aojea commented Jul 31, 2025

we need to update also the docs that are using v1beta1 in most places

@michaelasp
Copy link
Collaborator Author

we need to update also the docs that are using v1beta1 in most places

Yep, my idea was to let this be a code/test change and have a doc change follow up after.

@aojea
Copy link
Collaborator

aojea commented Aug 6, 2025

@michaelasp
Copy link
Collaborator Author

Yep, waiting on the packages to get cut, e.g https://pkg.go.dev/k8s.io/api/core/v1?tab=versions

@BenTheElder do you happen to know when those generally get released?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move PCI Root Helper Function to Kubernetes Library

4 participants