-
Notifications
You must be signed in to change notification settings - Fork 24
chore: Update DRA API to v1 in examples #195
Conversation
ce0e0ca to
0a677ab
Compare
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Please submit when appropriate)
|
Great, thanks, we need to wait until Aug 27th https://www.kubernetes.dev/resources/release/ |
|
Let's also take an AI of updating the KIND node images to use 1.34 version (I don't seem them available right now sadly) |
1.34 isn't released yet :-) |
|
Around the 1.34 release, we will also release a new kind version with the latest fixes, and new images. We try to release at least as often as Kubernetes, roughly. In between releases you can also test with ~arbitrary versions by pointing kind-build-node-image at one. @michaelasp has experience scripting this with CI and release builds of Kubernetes and there are details int he kind docs. |
Yeah I was wondering that maybe there's an RC version :) Not a biggie |
Yeah this should be done in #172, we build the node image from a release version we know has the GA APIs in KCP. Done here. @gauravkghildiyal is there anywhere else we want to do this? |
Oh sorry for not being specific. I was thinking about https://github.com/google/dranet/blob/main/kind.yaml. I think (maybe wrong) that our bats test does not build a custom KIND image and instead uses the one from the kind.yaml? |
I think that's done here, that one is just for users, however I should update the kind.yaml file as I assume the 1.34 node image will be released by then and that is mostly for users to use dranet. All our internal tests should be up to date though with 1.34 |
Ah, my bad, didn't spot that. Thanks for clarifying. |
(You don't have to build kube from source anymore for some time, you can use any k8s release and package it into a node image for the current kind version, there's some chance it won't work if kubernetes made a breaking change that isn't mitigated in your kind version yet -- https://kind.sigs.k8s.io/docs/user/quick-start/#building-images) |
|
1.34.0 is out and kind v0.30.0 defaults to it We should probably also setup CI flows that use kubernetes latest CI builds, in some later PR. |
|
1.34 has released, merging. |
Update to V1 apis in all examples, hold until GKE releases 1.34 and DRA is fully GA