-
Couldn't load subscription status.
- Fork 2.2k
Correct Enterprise upload url #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Enterprise upload url #1510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
=======================================
Coverage 68.05% 68.05%
=======================================
Files 94 94
Lines 8526 8526
=======================================
Hits 5802 5802
Misses 1843 1843
Partials 881 881
Continue to review full report at Codecov.
|
dd633f7 to
4658ba9
Compare
|
Can you please find an Enterprise documentation link and add that to a comment where these changes are located? |
|
I'm not sure the current url was ever correct, as I've been using it for a couple years with This does line up with the the documentation for Upload a release asset. Use the When testing the Github Enterprise API myself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @SteelPhase.
LGTM.
Awaiting second LGTM before merging.
|
I'm going to throw in a commit to update the description |
4658ba9 to
39b0595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the comments. I appreciate it.
|
Oh, and no need to force-push in this repo. We always "Squash and merge". Thanks. |
|
Oh good to know. I was wary and checked another PR, but thanks for letting me be slightly commit messy! |
Co-Authored-By: Ryan Mast <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you, @nightlark! |
The upload endpoint is not
/api/v3it is/api/uploadTested against Github Enterprise