Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SteelPhase
Copy link
Contributor

The upload endpoint is not /api/v3 it is /api/upload

Tested against Github Enterprise

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 26, 2020
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #1510 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1510   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files          94       94           
  Lines        8526     8526           
=======================================
  Hits         5802     5802           
  Misses       1843     1843           
  Partials      881      881           
Impacted Files Coverage Δ
github/github.go 89.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d007d...7f99eac. Read the comment docs.

@SteelPhase SteelPhase force-pushed the enterprise-upload-url branch from dd633f7 to 4658ba9 Compare April 26, 2020 21:11
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 26, 2020

Can you please find an Enterprise documentation link and add that to a comment where these changes are located?

@SteelPhase
Copy link
Contributor Author

SteelPhase commented Apr 26, 2020

I'm not sure the current url was ever correct, as I've been using it for a couple years with /api/uploads on Github Enterprise.

This does line up with the the documentation for Upload a release asset. Use the upload url returned in the response of the [Create a release endpoint] (https://developer.github.com/enterprise/2.20/v3/repos/releases/#create-a-release) to upload a release asset.

When testing the Github Enterprise API myself https://github.company.com/api/uploads/repos/test-org/test-repo/releases/1234/assets{?name,label} was returned by the Create a release endpoint

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SteelPhase.
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested review from gauntface and wesleimp April 26, 2020 21:40
@SteelPhase
Copy link
Contributor Author

I'm going to throw in a commit to update the description

@SteelPhase SteelPhase force-pushed the enterprise-upload-url branch from 4658ba9 to 39b0595 Compare April 26, 2020 21:50
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the comments. I appreciate it.

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 26, 2020

Oh, and no need to force-push in this repo. We always "Squash and merge". Thanks.

@SteelPhase
Copy link
Contributor Author

Oh good to know. I was wary and checked another PR, but thanks for letting me be slightly commit messy!

Copy link
Contributor

@nightlark nightlark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 28, 2020

Thank you, @nightlark!
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants