Remove redundancy in how token index is determined #1903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The side effect of #1832 has been that there are now two ways to determine if a header name is a token: one by using
h2o_iovec_is_token(which refers to the address of the name) and the other byh2o_header_is_token(which refers toh2o_header_t::flags.token_index_plus1. To keep the two consistent, we introducedh2o_validate_header.Now it seems to me that we can simplify the design by splitting
h2o_header_flags_tinto two structures:h2o_token_flags_tandh2o_header_flags_t.The only flag that needs to be configurable (from outside the HTTP protocol implementation) is the
dont_compressflag. We retain that inh2o_header_flags_tat the same time removing all the other fields.h2o_token_flags_tis now part ofh2o_token_t; functions that dealt with the redundant structure (i.e.h2o_validate_header,h2o_header_is_token) are removed.