send TLS alert before closing the socket, when OpenSSL is used and certificate verification fails (alternative to #2910) #2911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
694ee6e to
44b77c4
Compare
Merged
Member
Author
|
@robguima Thank you for the review. Let's go with this PR. |
Collaborator
|
great stuff! Sorry, forgot to mention that I did test this PR against the failing MTLS CI and it does seem to fix the issue. |
Member
Author
|
Thank you for confirming that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2910.
For the description of the problem and discussion, see #2910.